Re: [PATCH v2 07/16] efi: Make efi_status_to_err() public

joeyli
2015-08-27T09:06:47Z

On Thu, Aug 20, 2015 at 04:07:06PM +0100, Matt Fleming wrote:
> On Tue, 11 Aug, at 02:16:27PM, Lee, Chun-Yi wrote:
> > Moved the function of transferring EFI status to kernel error for
> > later used by EFI stub.
>
> Might I suggest:
>
> "Move the function for converting EFI status to kernel error values
> from drivers/firmware/efi/ to include/linux/efi.h for use by the x86
> EFI stub in an upcoming patch."
>
> ?
>

Thanks for your suggestion, I will follow it.

> > Reviewed-by: Jiri Kosina <jkosina@suse.com>
> > Tested-by: Jiri Kosina <jkosina@suse.com>
> > Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> > ---
> > drivers/firmware/efi/vars.c | 33 ---------------------------------
> > include/linux/efi.h | 33 +++++++++++++++++++++++++++++++++
> > 2 files changed, 33 insertions(+), 33 deletions(-)
>
> The patch content is fine,
>
> Reviewed-by: Matt Fleming <matt.fleming@intel.com>
>

Thanks

> --
> Matt Fleming, Intel Open Source Technology Center

Joey Lee