Re: [PATCH v2 08/16] x86/efi: Carrying hibernation key by setup data

Nigel Cunningham
2015-08-17T06:54:47Z

Hi all.

I've rejoined LKML, so I'll try to help with reviewing PM patches. I'd forgotten how much it is a case of sipping at a fire hydrant!

Regards,

Nigel

On 17/08/15 07:23, Jiri Kosina wrote:
> On Sat, 15 Aug 2015, Pavel Machek wrote:
>
>>> For forwarding hibernation key from EFI stub to boot kernel, this patch
>>> allocates setup data for carrying hibernation key, size and the status
>>> of efi operating.
>>>
>>> Reviewed-by: Jiri Kosina <jkosina@suse.com>
>> Jiri, are you sure you reviewed these? This is not really
>> english, afaict, and efi/EFI should be spelled consistently.
> Yes, I did review the code and the fact that it is still in compliance
> with my original idea. I think you can blame me on not reviewing
> changelogs super-rigorously though, so all suggestions for improvements
> are absolutely welcome.
>
> Thanks,
>