From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754380AbbHNKum (ORCPT <rfc822;w@1wt.eu>);
	Fri, 14 Aug 2015 06:50:42 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:44969 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752133AbbHNKul (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 14 Aug 2015 06:50:41 -0400
Date: Fri, 14 Aug 2015 13:50:26 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andrey Shvetsov <andrey.shvetsov.ml@gmail.com>
Cc: Joe Perches <joe@perches.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 07/19] staging: most: Remove unnecessary externs
Message-ID: <20150814105026.GC4496@mwanda>
References: <cover.1439241825.git.joe@perches.com>
 <bf9349f9a0cab6870fb1c169664e8175de7db439.1439241825.git.joe@perches.com>
 <20150814083635.GA4193@arch.fritz.box>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150814083635.GA4193@arch.fritz.box>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 14, 2015 at 10:36:35AM +0200, Andrey Shvetsov wrote:
> On Mon, Aug 10, 2015 at 02:51:22PM -0700, Joe Perches wrote:
> > Using 'extern' is not necessary for function prototypes.
> > 
> We use them to mark dependency inversions (callbacks).
> I thought about comments instead of, but I'm not sure what is worse.

I have never heard of anyone using the extern keyword to mean that
before so I feel like it doesn't work as a "putting extern means the
code documents itself".

regards,
dan carpenter