From: Ondrej Zary <linux@rainbow-software.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: staging: ft1000-pcmcia: remove support for v5 firmware
Date: Fri, 14 Aug 2015 21:14:05 +0200 [thread overview]
Message-ID: <201508142114.06209.linux@rainbow-software.org> (raw)
In-Reply-To: <20150814085017.GA30728@mwanda>
On Friday 14 August 2015 10:50:17 Dan Carpenter wrote:
> Hello Ondrej Zary,
>
> The patch e161a440af56: "staging: ft1000-pcmcia: remove support for
> v5 firmware" from Jul 1, 2011, leads to the following static checker
> warning:
>
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c:513 card_download()
> warn: condition implies we already warned.
>
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c
> 319 file_version = *(long *)pFileStart;
> 320 if (file_version != 6) {
>
> We only support version 6 now.
>
> 321 pr_err("unsupported firmware version %ld\n",
> file_version); 322 Status = FAILURE;
> 323 }
> 324
>
> [ snip ]
>
> 513 if (file_version == 5) {
>
> I think we can just delete this side of the if statement?
>
> 514 /*
> 515 * Position ASIC
> DPRAM auto-increment pointer. 516
> */
> 517
> ft1000_write_reg(dev, 518
> FT1000_REG_DPRAM_ADDR, 519
> DWNLD_PS_HDR_LOC); 520
> 521 for (; word_length
> > 0; word_length--) { /* In words */ 522
> temp = ntohs(*pUsData); 523
> ft1000_write_reg(dev, 524
>
> FT1000_REG_DPRAM_DATA, 525
> temp); 526
> pUsData++; 527
> }
> 528 } else {
> 529 /*
> 530 * Position ASIC
> DPRAM auto-increment pointer. 531
> */
> 532
> outw(DWNLD_MAG_PS_HDR_LOC, 533
> dev->base_addr + 534
> FT1000_REG_DPRAM_ADDR); 535
> if (word_length & 0x01) 536
> word_length++; 537
> 538 word_length =
> word_length / 2; 539
> 540 for (; word_length
> > 0; word_length--) { /* In words */ 541
> templong = *pUsData++; 542
> templong |= 543
> (*pUsData++ << 16); 544
> outl(templong, 545
> dev->base_addr + 546
>
> FT1000_REG_MAG_DPDATAL); 547
> }
> 548 }
>
> regards,
> dan carpenter
Most probably yes.
However, the driver will be useless soon as the Flash OFDM network is being
decommissioned here in Slovakia. AFAIK, this technology is not used anywhere
else in the world (the 2nd country was Finland). The ft1000 devices will be
left with no signal.
--
Ondrej Zary
next parent reply other threads:[~2015-08-14 19:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150814085017.GA30728@mwanda>
2015-08-14 19:14 ` Ondrej Zary [this message]
2015-08-17 14:35 ` staging: ft1000-pcmcia: remove support for v5 firmware Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201508142114.06209.linux@rainbow-software.org \
--to=linux@rainbow-software.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox