* [PATCH] mtd: spi-nor: Add support for sst25wf020a.
@ 2015-08-14 17:35 Alexis Ballier
2015-08-14 20:45 ` Marek Vasut
2015-09-02 20:56 ` Brian Norris
0 siblings, 2 replies; 5+ messages in thread
From: Alexis Ballier @ 2015-08-14 17:35 UTC (permalink / raw)
To: aballier
Cc: David Woodhouse, Brian Norris, Rafał Miłecki,
Marek Vasut, Huang Shijie, Gabor Juhos, Ben Hutchings,
Bean Huo 霍斌斌 (beanhuo),
open list:MEMORY TECHNOLOGY DEVICES (MTD), open list
It is a 256KiB flash with 4 KiB erase sectors
and 64KiB overlay blocks.
This is the one available on Hardkernel's Odroid U3 shield.
Signed-off-by: Alexis Ballier <aballier@gentoo.org>
---
drivers/mtd/spi-nor/spi-nor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index d78831b..e521b35 100644
--- a/drivers/mtd/spi-nor/spi-nor.c
+++ b/drivers/mtd/spi-nor/spi-nor.c
@@ -636,6 +636,7 @@ static const struct spi_device_id spi_nor_ids[] = {
{ "sst25wf512", INFO(0xbf2501, 0, 64 * 1024, 1, SECT_4K | SST_WRITE) },
{ "sst25wf010", INFO(0xbf2502, 0, 64 * 1024, 2, SECT_4K | SST_WRITE) },
{ "sst25wf020", INFO(0xbf2503, 0, 64 * 1024, 4, SECT_4K | SST_WRITE) },
+ { "sst25wf020a", INFO(0x621612, 0, 64 * 1024, 4, SECT_4K) },
{ "sst25wf040", INFO(0xbf2504, 0, 64 * 1024, 8, SECT_4K | SST_WRITE) },
{ "sst25wf080", INFO(0xbf2505, 0, 64 * 1024, 16, SECT_4K | SST_WRITE) },
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: spi-nor: Add support for sst25wf020a.
2015-08-14 17:35 [PATCH] mtd: spi-nor: Add support for sst25wf020a Alexis Ballier
@ 2015-08-14 20:45 ` Marek Vasut
2015-08-15 8:38 ` Alexis Ballier
2015-09-02 20:56 ` Brian Norris
1 sibling, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2015-08-14 20:45 UTC (permalink / raw)
To: Alexis Ballier
Cc: David Woodhouse, Brian Norris, Rafał Miłecki,
Huang Shijie, Gabor Juhos, Ben Hutchings,
Bean Huo 霍斌斌 (beanhuo),
open list:MEMORY TECHNOLOGY DEVICES (MTD), open list
On Friday, August 14, 2015 at 07:35:39 PM, Alexis Ballier wrote:
> It is a 256KiB flash with 4 KiB erase sectors
> and 64KiB overlay blocks.
>
> This is the one available on Hardkernel's Odroid U3 shield.
>
> Signed-off-by: Alexis Ballier <aballier@gentoo.org>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index d78831b..e521b35 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -636,6 +636,7 @@ static const struct spi_device_id spi_nor_ids[] = {
> { "sst25wf512", INFO(0xbf2501, 0, 64 * 1024, 1, SECT_4K | SST_WRITE)
},
> { "sst25wf010", INFO(0xbf2502, 0, 64 * 1024, 2, SECT_4K | SST_WRITE)
},
> { "sst25wf020", INFO(0xbf2503, 0, 64 * 1024, 4, SECT_4K | SST_WRITE)
},
> + { "sst25wf020a", INFO(0x621612, 0, 64 * 1024, 4, SECT_4K) },
Is the SST_WRITE not needed on this device ?
Otherwise, looks pretty obvious :)
> { "sst25wf040", INFO(0xbf2504, 0, 64 * 1024, 8, SECT_4K | SST_WRITE)
},
> { "sst25wf080", INFO(0xbf2505, 0, 64 * 1024, 16, SECT_4K | SST_WRITE)
},
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: spi-nor: Add support for sst25wf020a.
2015-08-14 20:45 ` Marek Vasut
@ 2015-08-15 8:38 ` Alexis Ballier
2015-08-15 13:29 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Alexis Ballier @ 2015-08-15 8:38 UTC (permalink / raw)
To: Marek Vasut
Cc: Ben Hutchings, Rafał Miłecki, open list, Gabor Juhos,
open list:MEMORY TECHNOLOGY DEVICES (MTD), Huang Shijie,
Brian Norris, David Woodhouse,
Bean Huo 霍斌斌 (beanhuo)
On Fri, 14 Aug 2015 22:45:14 +0200
Marek Vasut <marex@denx.de> wrote:
> On Friday, August 14, 2015 at 07:35:39 PM, Alexis Ballier wrote:
> > It is a 256KiB flash with 4 KiB erase sectors
> > and 64KiB overlay blocks.
> >
> > This is the one available on Hardkernel's Odroid U3 shield.
> >
> > Signed-off-by: Alexis Ballier <aballier@gentoo.org>
> > ---
> > drivers/mtd/spi-nor/spi-nor.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c
> > b/drivers/mtd/spi-nor/spi-nor.c index d78831b..e521b35 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -636,6 +636,7 @@ static const struct spi_device_id spi_nor_ids[]
> > = { { "sst25wf512", INFO(0xbf2501, 0, 64 * 1024, 1, SECT_4K |
> > SST_WRITE)
> },
> > { "sst25wf010", INFO(0xbf2502, 0, 64 * 1024, 2, SECT_4K
> > | SST_WRITE)
> },
> > { "sst25wf020", INFO(0xbf2503, 0, 64 * 1024, 4, SECT_4K
> > | SST_WRITE)
> },
> > + { "sst25wf020a", INFO(0x621612, 0, 64 * 1024, 4,
> > SECT_4K) },
>
> Is the SST_WRITE not needed on this device ?
Tried that at first and it didn't work (writes were silently not
performed).
I'm no expert here, but I don't see anything about auto address
increment in the spec:
http://ww1.microchip.com/downloads/en/DeviceDoc/20005139E.pdf
and it uses the page program command (0x02).
Alexis.
[...]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: spi-nor: Add support for sst25wf020a.
2015-08-15 8:38 ` Alexis Ballier
@ 2015-08-15 13:29 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2015-08-15 13:29 UTC (permalink / raw)
To: Alexis Ballier
Cc: Ben Hutchings, Rafał Miłecki, open list, Gabor Juhos,
open list:MEMORY TECHNOLOGY DEVICES (MTD), Huang Shijie,
Brian Norris, David Woodhouse,
Bean Huo 霍斌斌 (beanhuo)
On Saturday, August 15, 2015 at 10:38:59 AM, Alexis Ballier wrote:
> On Fri, 14 Aug 2015 22:45:14 +0200
>
> Marek Vasut <marex@denx.de> wrote:
> > On Friday, August 14, 2015 at 07:35:39 PM, Alexis Ballier wrote:
> > > It is a 256KiB flash with 4 KiB erase sectors
> > > and 64KiB overlay blocks.
> > >
> > > This is the one available on Hardkernel's Odroid U3 shield.
> > >
> > > Signed-off-by: Alexis Ballier <aballier@gentoo.org>
> > > ---
> > >
> > > drivers/mtd/spi-nor/spi-nor.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/mtd/spi-nor/spi-nor.c
> > > b/drivers/mtd/spi-nor/spi-nor.c index d78831b..e521b35 100644
> > > --- a/drivers/mtd/spi-nor/spi-nor.c
> > > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > > @@ -636,6 +636,7 @@ static const struct spi_device_id spi_nor_ids[]
> > > = { { "sst25wf512", INFO(0xbf2501, 0, 64 * 1024, 1, SECT_4K |
> > > SST_WRITE)
> >
> > },
> >
> > > { "sst25wf010", INFO(0xbf2502, 0, 64 * 1024, 2, SECT_4K
> > >
> > > | SST_WRITE)
> >
> > },
> >
> > > { "sst25wf020", INFO(0xbf2503, 0, 64 * 1024, 4, SECT_4K
> > >
> > > | SST_WRITE)
> >
> > },
> >
> > > + { "sst25wf020a", INFO(0x621612, 0, 64 * 1024, 4,
> > > SECT_4K) },
> >
> > Is the SST_WRITE not needed on this device ?
>
> Tried that at first and it didn't work (writes were silently not
> performed).
This is the worst possible behavior.
> I'm no expert here, but I don't see anything about auto address
> increment in the spec:
> http://ww1.microchip.com/downloads/en/DeviceDoc/20005139E.pdf
> and it uses the page program command (0x02).
They probably decided to start rolling out a standard SPI NOR, which is good :)
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: spi-nor: Add support for sst25wf020a.
2015-08-14 17:35 [PATCH] mtd: spi-nor: Add support for sst25wf020a Alexis Ballier
2015-08-14 20:45 ` Marek Vasut
@ 2015-09-02 20:56 ` Brian Norris
1 sibling, 0 replies; 5+ messages in thread
From: Brian Norris @ 2015-09-02 20:56 UTC (permalink / raw)
To: Alexis Ballier
Cc: David Woodhouse, Rafał Miłecki, Marek Vasut,
Huang Shijie, Gabor Juhos, Ben Hutchings,
Bean Huo 霍斌斌 (beanhuo),
open list:MEMORY TECHNOLOGY DEVICES (MTD), open list
On Fri, Aug 14, 2015 at 07:35:39PM +0200, Alexis Ballier wrote:
> It is a 256KiB flash with 4 KiB erase sectors
> and 64KiB overlay blocks.
>
> This is the one available on Hardkernel's Odroid U3 shield.
>
> Signed-off-by: Alexis Ballier <aballier@gentoo.org>
Applied to l2-mtd.git
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-09-02 20:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-14 17:35 [PATCH] mtd: spi-nor: Add support for sst25wf020a Alexis Ballier
2015-08-14 20:45 ` Marek Vasut
2015-08-15 8:38 ` Alexis Ballier
2015-08-15 13:29 ` Marek Vasut
2015-09-02 20:56 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox