From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Maxime Lorrillere <maxime.lorrillere@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: lustre: fix static declarations in libcfs
Date: Fri, 14 Aug 2015 18:49:46 -0700 [thread overview]
Message-ID: <20150815014946.GA19664@kroah.com> (raw)
In-Reply-To: <20150814140031.GA31688@gmail.com>
On Fri, Aug 14, 2015 at 04:00:31PM +0200, Maxime Lorrillere wrote:
> On vendredi 14 août 2015 à 11:28:35 (+0530), Sudip Mukherjee wrote
> > On Wed, Aug 12, 2015 at 11:51:04AM +0200, Maxime Lorrillere wrote:
> > > This patch fix the following sparse warnings in libcfs/linux/linux-debug.c:
> > > >>> linux-debug.c:64:6: warning: symbol 'lnet_upcall' was not declared. Should it be static?
> > > >>> linux-debug.c:65:6: warning: symbol 'lnet_debug_log_upcall' was not declared. Should it be static?
> > >
> > > Signed-off-by: Maxime Lorrillere <maxime.lorrillere@gmail.com>
> > > ---
> > You have not build tested.
> >
> > WARNING: "lnet_debug_log_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!
> > WARNING: "lnet_upcall" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!
>
> Sorry, I've only rebuild lustre separately.
>
> Patch 2/2 builds fine, should I submit it separately ?
Yes please.
prev parent reply other threads:[~2015-08-15 1:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 9:51 [PATCH 1/2] staging: lustre: fix static declarations in libcfs Maxime Lorrillere
2015-08-12 9:51 ` [PATCH 2/2] staging: lustre: fix symbol redeclared with different type " Maxime Lorrillere
2015-08-14 5:58 ` [PATCH 1/2] staging: lustre: fix static declarations " Sudip Mukherjee
2015-08-14 14:00 ` Maxime Lorrillere
2015-08-15 1:49 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150815014946.GA19664@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.lorrillere@gmail.com \
--cc=oleg.drokin@intel.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox