Re: [PATCH] mm/memblock: validate the creation of debugfs files

Alexander Kuleshov
2015-08-15T07:49:16Z

On 08-15-15, Andrew Morton wrote:
> Yes, I agree that if memblock's debugfs_create_file() fails, we want to
> know about it because something needs fixing. But that's true of
> all(?) debugfs_create_file callsites, so it's a bit silly to add
> warnings to them all. Why not put the warning into
> debugfs_create_file() itself?

Good idea, but there are already some debugfs_create_file calls with checks and
warning, if these checks failed. I don't know how many, but I saw it.
Double warning is not good too.