Re: [RFCv5 PATCH 38/46] sched: scheduler-driven cpu frequency selection

Steve Muckle
2015-09-29T00:26:59Z

Hi Punit,

On 09/28/2015 09:48 AM, Punit Agrawal wrote:
> Hi Mike,
>
> I ran into an issue when using this patch. Posting it here as this is
> the latest posting I can find.
>
> Morten Rasmussen <morten.rasmussen@arm.com> writes:
>
>> From: Michael Turquette <mturquette@baylibre.com>
>>
...
>> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
>> index 1f2c9a1..30241c9 100644
>> --- a/include/linux/cpufreq.h
>> +++ b/include/linux/cpufreq.h
>> @@ -494,6 +494,9 @@ extern struct cpufreq_governor cpufreq_gov_ondemand;
>> #elif defined(CONFIG_CPU_FREQ_DEFAULT_GOV_CONSERVATIVE)
>> extern struct cpufreq_governor cpufreq_gov_conservative;
>> #define CPUFREQ_DEFAULT_GOVERNOR (&cpufreq_gov_conservative)
>> +#elif defined(CONFIG_CPU_FREQ_DEFAULT_GOV_SCHED_GOV)
>> +extern struct cpufreq_governor cpufreq_gov_sched_gov;
>> +#define CPUFREQ_DEFAULT_GOVERNOR (&cpufreq_gov_sched)
>> #endif
>
> You have extra 'gov' in CONFIG_CPU_FREQ_DEFAULT_GOV_SCHED_GOV and
> cpufreq_gov_sched_gov above.

Thanks, this was pointed out earlier and will be fixed in subsequent
revisions of the patchset.