Re: [RFCv5 PATCH 39/46] sched/cpufreq_sched: use static key for cpu frequency selection

Peter Zijlstra
2015-08-15T19:51:37Z

On Wed, Jul 08, 2015 at 08:19:56AM -0700, Michael Turquette wrote:
> > @@ -254,6 +267,7 @@ static int cpufreq_sched_stop(struct cpufreq_policy *policy)
> > {
> > struct gov_data *gd = policy->governor_data;
> >
> > + clear_sched_energy_freq();
>
> <paranoia>
>
> These controls are exposed to userspace via cpufreq sysfs knobs. Should
> we use a struct static_key_deferred and static_key_slow_dec_deferred()
> instead? This helps avoid a possible attack vector for slowing down the
> system.
>
> </paranoia>
>
> I don't really know what a sane default rate limit would be in that case
> though. Otherwise feel free to add:

Exposed through being able to change the policy, right? No other new
knobs, right?

IIRC the policy is only writable by root, in which case deferred isn't
really needed, root can kill the machine many other ways.