Re: [RFCv5 PATCH 01/46] arm: Frequency invariant scheduler load-tracking support

Morten Rasmussen
2015-08-14T16:05:10Z

On Tue, Aug 11, 2015 at 11:27:54AM +0200, Peter Zijlstra wrote:
> On Tue, Jul 07, 2015 at 07:23:44PM +0100, Morten Rasmussen wrote:
> > +static DEFINE_PER_CPU(atomic_long_t, cpu_max_freq);
> > +DEFINE_PER_CPU(atomic_long_t, cpu_freq_capacity);
>
> > + atomic_long_set(&per_cpu(cpu_freq_capacity, cpu), capacity);
> > + unsigned long max = atomic_long_read(&per_cpu(cpu_max_freq, cpu));
> > + atomic_long_set(&per_cpu(cpu_max_freq, i), policy->max);
> > + unsigned long curr = atomic_long_read(&per_cpu(cpu_freq_capacity, cpu));
>
> The use of atomic_long_t here is entirely pointless.

Yes, I will get rid of those.