Re: [RFCv5 PATCH 20/46] sched: Relocated get_cpu_usage() and change return type

Peter Zijlstra
2015-08-12T10:59:30Z

On Tue, Jul 07, 2015 at 07:24:03PM +0100, Morten Rasmussen wrote:
> +static unsigned long get_cpu_usage(int cpu)
> +{
> + int sum;
> + unsigned long usage = cpu_rq(cpu)->cfs.utilization_load_avg;
> + unsigned long blocked = cpu_rq(cpu)->cfs.utilization_blocked_avg;
> + unsigned long capacity_orig = capacity_orig_of(cpu);
> +
> + sum = usage + blocked;
> +
> + if (sum >= capacity_orig)
> + return capacity_orig;
> +
> + return sum;
> +}

Should sum then not also be unsigned long?