From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944AbbHQCT3 (ORCPT ); Sun, 16 Aug 2015 22:19:29 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34440 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752134AbbHQCT2 (ORCPT ); Sun, 16 Aug 2015 22:19:28 -0400 Date: Mon, 17 Aug 2015 07:49:23 +0530 From: Viresh Kumar To: Mark Brown Cc: linaro-kernel@lists.linaro.org, sboyd@codeaurora.org, nm@ti.com, Liam Girdwood , "open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK" Subject: Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet() Message-ID: <20150817021923.GM1162@linux> References: <28971ff9b110d18970fcc6291531f617cda18230.1439553400.git.viresh.kumar@linaro.org> <20150814162506.GV10748@sirena.org.uk> <20150815031149.GD1162@linux> <20150815140805.GB10748@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150815140805.GB10748@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-08-15, 07:08, Mark Brown wrote: > On Sat, Aug 15, 2015 at 08:41:49AM +0530, Viresh Kumar wrote: > > > Hopefully below version looks better ? > > Please don't bury patches at the end of replies to messages in the > middle of threads, send them in a form where they can be applied > directly. Okay. I thought its fine to send patches like this and this can be applied directly with the --scissors option to git am or with mailinfo.scissors option set in configuration file. But will surely send patches separately to you. > > Subject: [PATCH] regulator: core: Define regulator_set_voltage_triplet() > > > > The OPP (Operating performance points) v2 bindings allows regulator > > voltage to be supplied as a triplet of voltages. > > > > Add regulator_set_voltage_triplet() API in regulator core to support > > that. > > This should explain why this is useful at a regulator API level, not > explain that some user decided to do something. Okay. > > +static inline int regulator_set_voltage_triplet(struct regulator *regulator, > > + int min_uV, int target_uV, > > + int max_uV) > > +{ > > + if (!regulator_set_voltage(regulator, target_uV, max_uV)) > > Make this a check for == 0 which is what you mean here, this isn't a > boolean function. Okay. -- viresh