Re: [PATCH] regulator: core: Define regulator_set_voltage_triplet()

Mark Brown
2015-08-15T02:11:34Z

[-- Attachment #1: Type: text/plain, Size: 978 bytes --]

On Fri, Aug 14, 2015 at 05:30:55PM +0530, Viresh Kumar wrote:

> The OPP (Operating performance points) v2 bindings allows regulator
> voltage to be supplied as a triplet of <target min max> voltages.

Looking at this I really don't understand why you tried to get me to
review this via an IRC pastebin instead of following the normal patch
submission process. Please don't do that, it's not at all helpful. IRC
can be useful for interactive discussions or things that are really
urgent, not for normal upstream code review.

> +static inline int regulator_set_voltage_triplet(struct regulator *regulator,
> + int target_uV, int min_uV,
> + int max_uV)

This seems awkward, these things are normally written as min <= target
<= max but this is target, min, max.

> static inline int regulator_set_voltage_tol(struct regulator *regulator,
> int new_uV, int tol_uV)
> {
> --
> 2.4.0

You've not added a stub for the new function.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]