From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753810AbbHQKKf (ORCPT ); Mon, 17 Aug 2015 06:10:35 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:35571 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbbHQKKV (ORCPT ); Mon, 17 Aug 2015 06:10:21 -0400 Date: Mon, 17 Aug 2015 12:09:14 +0200 From: Thierry Reding To: Alexandre Belloni Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Boris Brezillon , Nicolas Ferre , linux-kernel@vger.kernel.org, Josh Wu Subject: Re: [PATCH] drm: panel: simple: add QiaoDian qd43003c0-40 Message-ID: <20150817100913.GA8453@ulmo.nvidia.com> References: <1438382671-10098-1-git-send-email-alexandre.belloni@free-electrons.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2oS5YaxWCcQjTEyO" Content-Disposition: inline In-Reply-To: <1438382671-10098-1-git-send-email-alexandre.belloni@free-electrons.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 01, 2015 at 12:44:31AM +0200, Alexandre Belloni wrote: > From: Josh Wu >=20 > The QiaoDian Xianshi QD43003C0-40 is a 4"3 TFT LCD panel. >=20 > Timings from the OTA5180A document, ver 0.9, section > 10.1.1: > http://www.orientdisplay.com/pdf/OTA5180A.pdf >=20 > Signed-off-by: Josh Wu > Signed-off-by: Alexandre Belloni > --- > .../devicetree/bindings/panel/qd,qd43003c0-40.txt | 7 ++++++ > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++= ++++++ > 2 files changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/panel/qd,qd43003c0-= 40.txt You didn't run this through scripts/get_maintainer.pl, did you? It would also help to use the standard prefix ("drm/panel: ") because I end up filtering for that occasionally in case somebody didn't Cc me on panel patches. I only came across this by accident, and it's going to miss 4.3 now. Also two comments below... > diff --git a/Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt = b/Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt > new file mode 100644 > index 000000000000..900bc6ebeaff > --- /dev/null > +++ b/Documentation/devicetree/bindings/panel/qd,qd43003c0-40.txt > @@ -0,0 +1,7 @@ > +QiaoDian XianShi Corporation 4"3 TFT LCD panel > + > +Required properties: > +- compatible: should be "qd,qd43003c0-40" > + > +This binding is compatible with the simple-panel binding, which is speci= fied > +in simple-panel.txt in this directory. I don't see a vendor prefix for QiaoDian XianShi Corporation in Documentation/devicetree/bindings/vendor-prefixes.txt. > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel= /panel-simple.c > index f94201b6e882..e688fa545ae3 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -967,6 +967,29 @@ static const struct panel_desc ortustech_com43h4m85u= lc =3D { > .bus_format =3D MEDIA_BUS_FMT_RGB888_1X24, > }; > =20 > +static const struct drm_display_mode qd43003c0_40_mode =3D { > + .clock =3D 9000, > + .hdisplay =3D 480, > + .hsync_start =3D 480 + 8, > + .hsync_end =3D 480 + 8 + 4, > + .htotal =3D 480 + 8 + 4 + 39, > + .vdisplay =3D 272, > + .vsync_start =3D 272 + 4, > + .vsync_end =3D 272 + 4 + 10, > + .vtotal =3D 272 + 4 + 10 + 2, > + .vrefresh =3D 60, > +}; > + > +static const struct panel_desc qd43003c0_40 =3D { > + .modes =3D &qd43003c0_40_mode, > + .num_modes =3D 1, > + .size =3D { > + .width =3D 95, > + .height =3D 53, > + }, > + .bus_format =3D MEDIA_BUS_FMT_RGB888_1X24, > +}; Can you also add .bpc =3D 8 above so that drivers that don't support the =2Ebus_format can still support this panel? Thierry --2oS5YaxWCcQjTEyO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJV0bLGAAoJEN0jrNd/PrOhWuwQAK3ALkiCSTbql6YunzyjRg9X rbX9ZtOmcnOh1fiuVljTL2CKIPuRjTi5Hfogqvra0f8omJwGb1IMueWazwQaLRdl EKjVXkLSxxjcJEAHI8ILdzFgoYHS906S03OHPCrc0ULbPh4Q8D6Q2Zj1dtJ4ogUD S7H1Jv/at67EPZeSEx9PcL6KOh1hsoxvdDWMUP3MHpg1xNNp0E+XfXIsVeeg5JTB TFJjRWvyFgp9gW+Fq3DYAq+sMcgyYfSgO2xY6y/NvoVBfpPFwN0OEAjHc1nqD8us ZrOFAvJrd2lx6TWrc7t+a+PykoDV9IMeOFh775PcgoM5vxB3S87ZwPn3ZhVLW16s sk7YyJaslRwMoDNZ5VFFgEq8y/QUXiEvQ89tSWZRBK31lUYDbR7gClzG/CQJ7ri7 1WrtJFYzSzmANY6wKyzAx3LO1tuQwcNepLOCyUoGbAj+Uj3cNv13Jb3WqmZc9M7y AkczB7PCkAwBMfqLKHlFGC9JZqiSBFGSjlsHwVoqzYbunWwo9L7/0OIuVwAvl545 dinuvi/+azRv4GIQpJpLEvgJyHHMZM/netba0Qrh/HbAj5E78MYkStbvHYJO0/+h BGbrwWNuACKIa/WF5eoge/PFpdm0FvLM1Qq/yhF5FVQDsBEyiy5MdX3MYKglyDw/ tqQzrlgYEIFJ38r4Lky/ =ZxAr -----END PGP SIGNATURE----- --2oS5YaxWCcQjTEyO--