From: Matt Fleming <matt@codeblueprint.co.uk>
To: Kanaka Juvva <kanaka.d.juvva@linux.intel.com>
Cc: kanaka.d.juvva@intel.com, glenn.p.williamson@intel.com,
matt.fleming@intel.com, will.auld@intel.com, andi@firstfloor.org,
linux-kernel@vger.kernel.org, tony.luck@intel.com,
peterz@infradead.org, tglx@linutronix.de, tj@kernel.org,
x86@kernel.org, mingo@redhat.com, hpa@zytor.com,
vikas.shivappa@intel.com
Subject: Re: [PATCH v3 2/2] perf,x86: skip intel_cqm_stable if CMT is not present in a CPU model
Date: Mon, 17 Aug 2015 14:16:58 +0100 [thread overview]
Message-ID: <20150817131658.GC3233@codeblueprint.co.uk> (raw)
In-Reply-To: <1439019379-10025-1-git-send-email-kanaka.d.juvva@linux.intel.com>
On Sat, 08 Aug, at 12:36:19AM, Kanaka Juvva wrote:
> CMT and MBM are complementary technologies. One technology doesn't
> imply the other technology. If CMT is not present in your CPU model
> intel_cqm_stable() won't be called when computing a free RMID. This
> is because, LLC_OCCUPANCY reading in this case doesn't apply and
> shouldn't be used a criteria for freeing or picking an RMID.
>
> Signed-off-by: Kanaka Juvva <kanaka.d.juvva@linux.intel.com>
> ---
> arch/x86/kernel/cpu/perf_event_intel_cqm.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
Shouldn't this patch be the first one in the series?
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-08-17 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-08 7:36 [PATCH v3 2/2] perf,x86: skip intel_cqm_stable if CMT is not present in a CPU model Kanaka Juvva
2015-08-17 13:16 ` Matt Fleming [this message]
2015-08-18 17:09 ` Matt Fleming
2015-08-20 10:41 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817131658.GC3233@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=andi@firstfloor.org \
--cc=glenn.p.williamson@intel.com \
--cc=hpa@zytor.com \
--cc=kanaka.d.juvva@intel.com \
--cc=kanaka.d.juvva@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=vikas.shivappa@intel.com \
--cc=will.auld@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox