From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755587AbbHQQGR (ORCPT ); Mon, 17 Aug 2015 12:06:17 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:35073 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752591AbbHQQGP (ORCPT ); Mon, 17 Aug 2015 12:06:15 -0400 Date: Mon, 17 Aug 2015 09:06:15 -0700 From: Greg KH To: Philipp Hachtmann Cc: johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] USB: symbolserial: Use usb_get_serial_port_data Message-ID: <20150817160615.GB6477@kroah.com> References: <1439825507-12076-1-git-send-email-hachti@hachti.de> <1439825507-12076-2-git-send-email-hachti@hachti.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439825507-12076-2-git-send-email-hachti@hachti.de> User-Agent: Mutt/1.5.23+102 (2ca89bed6448) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 17, 2015 at 05:31:46PM +0200, Philipp Hachtmann wrote: > The driver used usb_get_serial_data(port->serial) which compiled but resulted > in a NULL pointer being returned (and subsequently used). I did not go deeper > into this but I guess this is a regression. > > Signed-off-by: Philipp Hachtmann > --- > drivers/usb/serial/symbolserial.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Doh, obviously no one has used this driver in a long time, thanks for these patches... Johan, mind if I take these directly? thanks, greg k-h