From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752677AbbHQRQ2 (ORCPT ); Mon, 17 Aug 2015 13:16:28 -0400 Received: from mga14.intel.com ([192.55.52.115]:51704 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750799AbbHQRQ1 (ORCPT ); Mon, 17 Aug 2015 13:16:27 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,696,1432623600"; d="scan'208";a="785769308" Date: Mon, 17 Aug 2015 22:48:31 +0530 From: Vinod Koul To: Robert Baldyga Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, k.kozlowski@samsung.com Subject: Re: [PATCH] dmaengine: fix balance of privatecnt inc/dec operations Message-ID: <20150817171831.GR13546@localhost> References: <1438943207-4840-1-git-send-email-r.baldyga@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438943207-4840-1-git-send-email-r.baldyga@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 07, 2015 at 12:26:47PM +0200, Robert Baldyga wrote: > This patch increments privatecnt value and set DMA_PRIVATE in device > caps in dma_request_slave_channel() function. This is needed to keep > privatecnt increment/decrement balance. > > As function dma_release_channel() decrements privatecnt counter, we need > to increment it when channel is requested. Otherwise privatecnt drops > into negatives after few dma_release_channel() calls. Applied, thanks -- ~Vinod