From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751632AbbHQSB1 (ORCPT ); Mon, 17 Aug 2015 14:01:27 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:35328 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbbHQSBZ (ORCPT ); Mon, 17 Aug 2015 14:01:25 -0400 Date: Mon, 17 Aug 2015 20:01:22 +0200 From: Johan Hovold To: Greg KH Cc: Philipp Hachtmann , johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] USB: symbolserial: Use usb_get_serial_port_data Message-ID: <20150817180122.GJ7053@localhost> References: <1439825507-12076-1-git-send-email-hachti@hachti.de> <1439825507-12076-2-git-send-email-hachti@hachti.de> <20150817160615.GB6477@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150817160615.GB6477@kroah.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 17, 2015 at 09:06:15AM -0700, Greg Kroah-Hartman wrote: > On Mon, Aug 17, 2015 at 05:31:46PM +0200, Philipp Hachtmann wrote: > > The driver used usb_get_serial_data(port->serial) which compiled but resulted > > in a NULL pointer being returned (and subsequently used). I did not go deeper > > into this but I guess this is a regression. > > > > Signed-off-by: Philipp Hachtmann > > --- > > drivers/usb/serial/symbolserial.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > Doh, obviously no one has used this driver in a long time, thanks for > these patches... Wow... > Johan, mind if I take these directly? Please do. This one should be tagged: Fixes: a85796ee5149 ("USB: symbolserial: move private-data allocation to port_probe") Cc: stable # v3.10 And for both patches: Acked-by: Johan Hovold Thanks, Johan