From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: "Raphaël Beamonte" <raphael.beamonte@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Greg Donald <gdonald@gmail.com>,
Cristina Opriceana <cristina.opriceana@gmail.com>
Subject: Re: [PATCH 07/20] staging: rtl8192u: r8192_core: whitespace neatening
Date: Tue, 18 Aug 2015 10:54:17 +0530 [thread overview]
Message-ID: <20150818052417.GD2941@sudip-pc> (raw)
In-Reply-To: <717595814bcdd3a5f95a9d046183cac41d44d791.1439688440.git.raphael.beamonte@gmail.com>
On Sat, Aug 15, 2015 at 09:34:03PM -0400, Raphaël Beamonte wrote:
> Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
> ---
<snip>
> @@ -2182,30 +2182,30 @@ static void rtl8192_init_priv_variable(struct net_device *dev)
> priv->EarlyRxThreshold = 7;
> priv->enable_gpio0 = 0;
> priv->TransmitConfig =
> - (TCR_MXDMA_2048<<TCR_MXDMA_OFFSET) | // Max DMA Burst Size per Tx DMA Burst, 7: reserved.
> - (priv->ShortRetryLimit<<TCR_SRL_OFFSET) | // Short retry limit
> - (priv->LongRetryLimit<<TCR_LRL_OFFSET) | // Long retry limit
> + (TCR_MXDMA_2048 << TCR_MXDMA_OFFSET) | // Max DMA Burst Size per Tx DMA Burst, 7: reserved.
> + (priv->ShortRetryLimit << TCR_SRL_OFFSET) | // Short retry limit
> + (priv->LongRetryLimit << TCR_LRL_OFFSET) | // Long retry limit
> (false ? TCR_SAT : 0); // FALSE: HW provides PLCP length and LENGEXT, TRUE: SW provides them
> #ifdef TO_DO_LIST
> if (Adapter->bInHctTest)
> pHalData->ReceiveConfig = pHalData->CSMethod |
> - RCR_AMF | RCR_ADF | //accept management/data
> + RCR_AMF | RCR_ADF | //accept management/data
> //guangan200710
> - RCR_ACF | //accept control frame for SW AP needs PS-poll, 2005.07.07, by rcnjko.
> - RCR_AB | RCR_AM | RCR_APM | //accept BC/MC/UC
> - RCR_AICV | RCR_ACRC32 | //accept ICV/CRC error packet
> - ((u32)7<<RCR_MXDMA_OFFSET) | // Max DMA Burst Size per Rx DMA Burst, 7: unlimited.
> - (pHalData->EarlyRxThreshold<<RCR_FIFO_OFFSET) | // Rx FIFO Threshold, 7: No Rx threshold.
> + RCR_ACF | //accept control frame for SW AP needs PS-poll, 2005.07.07, by rcnjko.
> + RCR_AB | RCR_AM | RCR_APM | //accept BC/MC/UC
> + RCR_AICV | RCR_ACRC32 | //accept ICV/CRC error packet
> + ((u32)7 << RCR_MXDMA_OFFSET) | // Max DMA Burst Size per Tx DMA Burst, 7: reserved.
looks like the comment has changed. copy paste error from previous
lines?
regards
sudip
next prev parent reply other threads:[~2015-08-18 5:24 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 1:33 [PATCH 00/20] staging: rtl8192u: r8192U_core: fix all checkpatch.pl reports Raphaël Beamonte
2015-08-16 1:33 ` [PATCH 01/20] staging: rtl8192u: r8192U_core: fix switch and case indent code style error Raphaël Beamonte
2015-08-16 1:33 ` [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing " Raphaël Beamonte
2015-08-18 5:02 ` Sudip Mukherjee
2015-08-18 5:38 ` Raphaël Beamonte
2015-08-18 5:44 ` Sudip Mukherjee
2015-08-18 6:02 ` Raphaël Beamonte
2015-08-18 6:14 ` Sudip Mukherjee
2015-08-16 1:33 ` [PATCH 03/20] staging: rtl8192u: t8192U_core: fix space before close parenthesis " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 04/20] staging: rtl8192u: r8192U_core: fix code indent using spaces " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 05/20] staging: rtl8192u: r8192U_core: fix else following close brace " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 06/20] staging: rtl8192u: r8192U_core: fix missing struct leading to consistent spacing " Raphaël Beamonte
2015-08-18 5:17 ` Sudip Mukherjee
2015-08-16 1:34 ` [PATCH 07/20] staging: rtl8192u: r8192_core: whitespace neatening Raphaël Beamonte
2015-08-18 5:24 ` Sudip Mukherjee [this message]
2015-08-16 1:34 ` [PATCH 08/20] staging: rtl8192u: r8192_core: clean C99 // comments Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 09/20] staging: rtl8192u: r8192U_core: include linux/uaccess.h instead of asm/uaccess.h Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 10/20] staging: rtl8192u: r8192U_core: remove return statement of void function Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 11/20] staging: rtl8192u: r8192U_core: fix unecessary braces code style issue Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 12/20] staging: rtl8192u: r8192U_core: fix externs in .c file " Raphaël Beamonte
2015-08-18 5:30 ` Sudip Mukherjee
2015-08-18 5:40 ` Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 13/20] staging: rtl8192u: r8192U_core: fix unnecessary check before kfree " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 14/20] staging: rtl8192u: r8192U_core: fix unnecessary parentheses " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 15/20] staging: rtl8192u: r8192U_core: fix unnecessary else after return " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 16/20] staging: rtl8192u: r8192U_core: fix unnecessary whitespace " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 17/20] staging: rtl8192u: r8192U_core: fix missing blank line after declarations " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 18/20] staging: rtl8192u: r8192U_core: fix quoted string split across lines " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 19/20] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() " Raphaël Beamonte
2015-08-16 1:34 ` [PATCH 20/20] staging: rtl8192u: r8192U_core: fix line over 80 characters " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 00/19] staging: rtl8192u: r8192U_core: fix all checkpatch.pl reports Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 01/19] staging: rtl8192u: r8192U_core: fix switch and case indent code style error Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 02/19] staging: rtl8192u: r8192U_core: fix space before close parenthesis " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 03/19] staging: rtl8192u: r8192U_core: fix code indent using spaces " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 04/19] staging: rtl8192u: r8192U_core: fix else following close brace " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 05/19] staging: rtl8192u: r8192U_core: fix missing struct leading to consistent spacing " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 06/19] staging: rtl8192u: r8192U_core: whitespace neatening to fix consistent spacing code style errors Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 07/19] staging: rtl8192u: r8192U_core: clean C99 // comments Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 08/19] staging: rtl8192u: r8192U_core: include linux/uaccess.h instead of asm/uaccess.h Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 09/19] staging: rtl8192u: r8192U_core: remove return statement of void function Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 10/19] staging: rtl8192u: r8192U_core: fix unecessary braces code style issue Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 11/19] staging: rtl8192u: r8192U_core: remove forward declarations in .c file Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 12/19] staging: rtl8192u: r8192U_core: fix unnecessary check before kfree code style issue Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 13/19] staging: rtl8192u: r8192U_core: fix unnecessary parentheses " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 14/19] staging: rtl8192u: r8192U_core: fix unnecessary else after return " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 15/19] staging: rtl8192u: r8192U_core: fix unnecessary whitespace " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 16/19] staging: rtl8192u: r8192U_core: fix missing blank line after declarations " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 17/19] staging: rtl8192u: r8192U_core: fix quoted string split across lines " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 18/19] staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() " Raphaël Beamonte
2015-09-03 17:00 ` Greg Kroah-Hartman
2015-09-05 22:16 ` Raphaël Beamonte
2015-09-06 0:44 ` Greg Kroah-Hartman
2015-09-06 2:15 ` [PATCHv2] " Raphaël Beamonte
2015-08-18 16:58 ` [PATCHv2 19/19] staging: rtl8192u: r8192U_core: fix line over 80 characters " Raphaël Beamonte
2015-08-19 10:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818052417.GD2941@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=cristina.opriceana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=raphael.beamonte@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox