From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752336AbbHRFo0 (ORCPT ); Tue, 18 Aug 2015 01:44:26 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:34380 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752213AbbHRFoY (ORCPT ); Tue, 18 Aug 2015 01:44:24 -0400 Date: Tue, 18 Aug 2015 11:14:15 +0530 From: Sudip Mukherjee To: =?iso-8859-1?Q?Rapha=EBl?= Beamonte Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Donald , Cristina Opriceana Subject: Re: [PATCH 02/20] staging: rtl8192u: r8192U_core: fix consistent spacing code style error Message-ID: <20150818054415.GF2941@sudip-pc> References: <20150818050222.GB2941@sudip-pc> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2015 at 01:38:21AM -0400, Raphaël Beamonte wrote: > 2015-08-18 1:02 GMT-04:00 Sudip Mukherjee : > > since you are modifying these lines for consistent spacing, it will be > > better to have: > > (priv->ShortRetryLimit << TCR_SRL_OFFSET) | // Short retry limit > > > This should be: > > priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID>>1)) >> 8; > > Are you talking about spacing around the << and >> ? > If so, shouldn't that last line be: > priv->eeprom_CustomerID = eprom_read(dev, (EEPROM_Customer_ID >> 1)) >> 8; yeah.. I missed that >>1 , i only noticed >>8 as you have changed that. > > And should I thus apply that to the whole file? I think that will be better, since you are sending the patch for consistent spacing. And some of your patches are not having any commit message. Greg will not accept such patches. So while you are sending take care of that also. regards sudip