From: Darren Hart <dvhart@infradead.org>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: "Łukasz Stelmach" <stlman@poczta.fm>,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] asus-laptop: Add key found on Asus F3M
Date: Mon, 17 Aug 2015 22:48:10 -0700 [thread overview]
Message-ID: <20150818054810.GA4060@vmdeb7> (raw)
In-Reply-To: <CAHR064g5YRt-ru=3wTzkrPFgNUPABmCuf9Lv086Pu=j7pfR7uQ@mail.gmail.com>
On Wed, Aug 12, 2015 at 09:06:08AM +0200, Corentin Chary wrote:
> On Wed, Aug 5, 2015 at 10:29 PM, Darren Hart <dvhart@infradead.org> wrote:
> > On Wed, Jul 29, 2015 at 09:31:23PM +0200, Łukasz Stelmach wrote:
> >> Asus F3M has two keys labeled with an icon of a touchpad. The first,
> >> reported as 0x6B is next to the power key and the second, reported as
> >> 0x6A, is F9 combined with Fn button. When I was pressing the latter, I was
> >> getting "Unknown key 6a pressed" message before applying this patch.
> >>
> >> Asus F3M does not support WMI so the commit does not update key mappings
> >> in the asus-nb-wmi.c file.
> >>
> >> I have not tested this mapping on any other Asus laptop.
> >>
> >> Signed-off-by: Łukasz Stelmach <stlman@poczta.fm>
> >
> > Thanks Łukasz.
> >
> > Corentin, any concerns?
>
> Acked-by: Corentin Chary <corentin.chary@gmail.com>
>
> Sorry for the delay, I won't really have a stable internet connection
> until October.
It's already in next, but thank you for following up.
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2015-08-18 5:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 17:17 [PATCH] asus-laptop: Add key found on Asus F3M Łukasz Stelmach
2015-07-29 4:43 ` Darren Hart
2015-07-29 19:31 ` [PATCH v2] " Łukasz Stelmach
2015-08-05 20:29 ` Darren Hart
2015-08-12 7:06 ` Corentin Chary
2015-08-18 5:48 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818054810.GA4060@vmdeb7 \
--to=dvhart@infradead.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stlman@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox