From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754121AbbHRVsp (ORCPT ); Tue, 18 Aug 2015 17:48:45 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:36711 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753950AbbHRVsm (ORCPT ); Tue, 18 Aug 2015 17:48:42 -0400 Date: Tue, 18 Aug 2015 14:46:08 -0700 From: Olof Johansson To: Javier Martinez Canillas Cc: arm@kernel.org, Arnd Bergmann , Geert Uytterhoeven , Doug Anderson , Gwendal Grignou , Sjoerd Simons , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: multi_v7_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver Message-ID: <20150818214608.GA21855@localhost> References: <1439881827-22613-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439881827-22613-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2015 at 09:10:27AM +0200, Javier Martinez Canillas wrote: > The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config > symbol because the driver uses some communication helper functions in > drivers/platform/chrome/cros_ec_proto.c but other drivers depends on > CROS_EC_PROTO instead. Mixing select and depends can lead to circular > Kconfig dependencies so the MFD_CROS_EC select should be changed to a > depends on CROS_EC_PROTO instead. > > But doing so will break git bisect-ability since MFD_CROS_EC will not > be enabled anymore unless the default configs first explicitly enable > the CROS_EC_PROTO dependency. > > Signed-off-by: Javier Martinez Canillas Applied to cros/ec-config in arm-soc, which will stay stable in case others need to bring in as a prereq. -Olof