From: Frederic Weisbecker <fweisbec@gmail.com>
To: Andy Lutomirski <luto@kernel.org>
Cc: X86 ML <x86@kernel.org>, Sasha Levin <sasha.levin@oracle.com>,
Brian Gerst <brgerst@gmail.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH] x86/entry/64: Context-track syscalls before enabling interrupts
Date: Wed, 19 Aug 2015 00:16:26 +0200 [thread overview]
Message-ID: <20150818221623.GA12858@lerouge> (raw)
In-Reply-To: <ad9154dd60f669e94e60d36d23c3267b2ac4c94d.1439924771.git.luto@kernel.org>
On Tue, Aug 18, 2015 at 12:11:59PM -0700, Andy Lutomirski wrote:
> This fixes a couple minor holes if we took an IRQ very early in syscall
> processing:
>
> - We could enter the IRQ with CONTEXT_USER. Everything worked (RCU
> was fine), but we could warn if all the debugging options were
> set.
So this is fixing issues after your changes that call user_exit() from
IRQs, right?
But the IRQs aren't supposed to call user_exit(), they have their own hooks.
That's where the real issue is.
next prev parent reply other threads:[~2015-08-18 22:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 19:11 [PATCH] x86/entry/64: Context-track syscalls before enabling interrupts Andy Lutomirski
2015-08-18 22:16 ` Frederic Weisbecker [this message]
2015-08-18 22:35 ` Andy Lutomirski
2015-08-18 23:02 ` Frederic Weisbecker
2015-08-18 23:07 ` Andy Lutomirski
2015-08-19 17:10 ` Frederic Weisbecker
2015-08-21 7:50 ` Ingo Molnar
2015-08-21 13:14 ` Frederic Weisbecker
2015-08-19 0:30 ` Andy Lutomirski
2015-08-19 15:54 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818221623.GA12858@lerouge \
--to=fweisbec@gmail.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox