From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbbHSKAf (ORCPT ); Wed, 19 Aug 2015 06:00:35 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:32808 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbbHSKAd (ORCPT ); Wed, 19 Aug 2015 06:00:33 -0400 Date: Wed, 19 Aug 2015 15:30:21 +0530 From: Sudip Mukherjee To: Fabio Estevam Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel Subject: Re: [PATCH 1/9] staging: most: NULL comparison style Message-ID: <20150819100021.GA9297@sudip-pc> References: <1439911108-20765-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2015 at 01:31:00PM -0300, Fabio Estevam wrote: > On Tue, Aug 18, 2015 at 12:18 PM, Sudip Mukherjee > wrote: > > According to the kernel coding style the NULL check should not be > > written as [variable] == NULL or [variable] != NULL. > > It seems this not documented in Documentation/CodingStyle . Yes, it is not in the CodingStyle file. But mostly it is the convention that is followed. And in CodingStyle file if you see the "The rationale for using gotos is:" section, you will see in the example function the test is done like: if (!buffer). Anyways, frankly speaking I know commit message is bad but I could not think of anything else other than the one I wrote. Any ideas please... regards sudip