From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754078AbbHSM7d (ORCPT ); Wed, 19 Aug 2015 08:59:33 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36677 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753984AbbHSM7c (ORCPT ); Wed, 19 Aug 2015 08:59:32 -0400 Date: Wed, 19 Aug 2015 13:59:27 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Gwendal Grignou , Doug Anderson , Bartlomiej Zolnierkiewicz , Wolfram Sang , Dmitry Torokhov , Geert Uytterhoeven , Olof Johansson Subject: Re: [PATCH 4/6] mfd: cros_ec: Remove CROS_EC_PROTO dependency for SPI and I2C drivers Message-ID: <20150819125927.GJ6180@x1> References: <1439983198-4696-1-git-send-email-javier@osg.samsung.com> <1439983198-4696-5-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1439983198-4696-5-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Aug 2015, Javier Martinez Canillas wrote: > The ChromeOS EC SPI and I2C transport drivers depends on CROS_EC_PROTO > but MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends > on is bad practice as it may lead to circular Kconfig dependencies. > > Since these drivers already depend on MFD_CROS_EC and that config option > already selects CROS_EC_PROTO, there is no need to make them explicitly > depend on CROS_EC_PROTO since that dependency is already met. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index feebc750aadf..99d63675f073 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -106,7 +106,7 @@ config MFD_CROS_EC > > config MFD_CROS_EC_I2C > tristate "ChromeOS Embedded Controller (I2C)" > - depends on MFD_CROS_EC && CROS_EC_PROTO && I2C > + depends on MFD_CROS_EC && I2C > > help > If you say Y here, you get support for talking to the ChromeOS > @@ -116,7 +116,7 @@ config MFD_CROS_EC_I2C > > config MFD_CROS_EC_SPI > tristate "ChromeOS Embedded Controller (SPI)" > - depends on MFD_CROS_EC && CROS_EC_PROTO && SPI > + depends on MFD_CROS_EC && SPI > > ---help--- > If you say Y here, you get support for talking to the ChromeOS EC -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog