From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932148AbbHSNAU (ORCPT ); Wed, 19 Aug 2015 09:00:20 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:33309 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301AbbHSNAR (ORCPT ); Wed, 19 Aug 2015 09:00:17 -0400 Date: Wed, 19 Aug 2015 14:00:12 +0100 From: Lee Jones To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Gwendal Grignou , Doug Anderson , Bartlomiej Zolnierkiewicz , Wolfram Sang , Dmitry Torokhov , Geert Uytterhoeven , Olof Johansson Subject: Re: [PATCH 1/6] mfd: Add MFD_CROS_EC dependencies Message-ID: <20150819130012.GK6180@x1> References: <1439983198-4696-1-git-send-email-javier@osg.samsung.com> <1439983198-4696-2-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1439983198-4696-2-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Aug 2015, Javier Martinez Canillas wrote: > The MFD_CROS_EC symbol select CHROME_PLATFORMS and CROS_EC_PROTO but > that caused a Kconfig unmet direct dependencies warning since these > symbols could only be selected for X86 || ARM. > > The fix it, the CHROME_PLATFORMS dependencies were relexed on commit > d12bbcd3ea44 ("platform/chrome: Don't make CHROME_PLATFORMS depends > on X86 || ARM") but that was found to be wrong and the correct fix > is to add the needed dependencies to the MFD_CROS_EC config symbol. > > There are only x86 and ARM based Chromebooks so to avoid showing up > the config option on unsupported platforms, make the symbol depend on > these architectures. Also add a || COMPILE_TEST so it can have build > coverage on other platforms. > > Suggested-by: Geert Uytterhoeven > Signed-off-by: Javier Martinez Canillas > --- > > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 3dfe7bd4022f..feebc750aadf 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -97,6 +97,7 @@ config MFD_CROS_EC > select MFD_CORE > select CHROME_PLATFORMS > select CROS_EC_PROTO > + depends on X86 || ARM || COMPILE_TEST > help > If you say Y here you get support for the ChromeOS Embedded > Controller (EC) providing keyboard, battery and power services. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog