From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbbHUCHZ (ORCPT ); Thu, 20 Aug 2015 22:07:25 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34596 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751749AbbHUCHY (ORCPT ); Thu, 20 Aug 2015 22:07:24 -0400 Date: Wed, 19 Aug 2015 09:18:34 -0700 From: Olof Johansson To: Javier Martinez Canillas Cc: arm@kernel.org, Arnd Bergmann , Geert Uytterhoeven , Doug Anderson , Gwendal Grignou , Sjoerd Simons , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] ARM: multi_v7_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver Message-ID: <20150819161834.GB21855@localhost> References: <1439881827-22613-1-git-send-email-javier@osg.samsung.com> <20150818214608.GA21855@localhost> <55D3B195.6030608@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55D3B195.6030608@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2015 at 12:28:37AM +0200, Javier Martinez Canillas wrote: > Hello Olof, > > On 08/18/2015 11:46 PM, Olof Johansson wrote: > > On Tue, Aug 18, 2015 at 09:10:27AM +0200, Javier Martinez Canillas wrote: > >> The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config > >> symbol because the driver uses some communication helper functions in > >> drivers/platform/chrome/cros_ec_proto.c but other drivers depends on > >> CROS_EC_PROTO instead. Mixing select and depends can lead to circular > >> Kconfig dependencies so the MFD_CROS_EC select should be changed to a > >> depends on CROS_EC_PROTO instead. > >> > >> But doing so will break git bisect-ability since MFD_CROS_EC will not > >> be enabled anymore unless the default configs first explicitly enable > >> the CROS_EC_PROTO dependency. > >> > >> Signed-off-by: Javier Martinez Canillas > > > > Applied to cros/ec-config in arm-soc, which will stay stable in case others > > need to bring in as a prereq. > > > > Thanks but Bartolomiej's feedback [0] on my patch that made CROS_EC_PROTO > a user selectable option was to leave it as a non-visible option and instead > change the other Kconfig symbols to select CROS_EC_PROTO consistently. > > So tomorrow I'll post a new patch series along those lines that will make > this patch obsolete since no defconfig changes will be needed. > > IOW, please drop this patch and sorry for the inconvenience. Done. -Olof