From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751562AbbHSQqL (ORCPT ); Wed, 19 Aug 2015 12:46:11 -0400 Received: from mga14.intel.com ([192.55.52.115]:57260 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbbHSQqJ (ORCPT ); Wed, 19 Aug 2015 12:46:09 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,711,1432623600"; d="scan'208";a="751639760" Date: Wed, 19 Aug 2015 22:18:16 +0530 From: Vinod Koul To: Han Xu Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] dmaengine: mxs: support i.MX7D and deep sleep mode Message-ID: <20150819164816.GI13546@localhost> References: <1438105753-22146-1-git-send-email-b45815@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438105753-22146-1-git-send-email-b45815@freescale.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 28, 2015 at 12:49:13PM -0500, Han Xu wrote: > From: Huang Shijie > > The patch support i.MX7D platform by adding extra DMA clock. > > Deep Sleep Mode(dsm) turns off the power for APBH DMA module, add > suspend/resume function and re-init the APBH DMA during resume. I have only 2/6, whats going on? > +static int mxs_dma_pm_suspend(struct device *dev) > +{ > + /* > + * We do not save any registers here, since the gpmi will release its > + * DMA channel. > + */ > + return 0; > +} Why do we need the empty fn? -- ~Vinod