From: Christian Gromm <christian.gromm@microchip.com>
To: Adrian Remonda <adrianremonda@gmail.com>
Cc: <gregkh@linuxfoundation.org>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv7 4/5] Staging: most: hdm-dim2/dim2_hal.c. Fix "Using plain integer as NULL pointer" warnings
Date: Wed, 19 Aug 2015 17:12:12 +0200 [thread overview]
Message-ID: <20150819171212.295ac863@muaddib> (raw)
In-Reply-To: <1439547484-20492-5-git-send-email-adrianremonda@gmail.com>
On Fri, 14 Aug 2015 12:18:03 +0200
Adrian Remonda <adrianremonda@gmail.com> wrote:
> This patch fixes the warning generated by sparse: "Using plain integer
> as NULL pointer" by replacing the offending 0 with NULL.
>
> Signed-off-by: Adrian Remonda <adrianremonda@gmail.com>
> ---
> drivers/staging/most/hdm-dim2/dim2_hal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/hdm-dim2/dim2_hal.c b/drivers/staging/most/hdm-dim2/dim2_hal.c
> index 01b748944ee4..a54cf2cedac3 100644
> --- a/drivers/staging/most/hdm-dim2/dim2_hal.c
> +++ b/drivers/staging/most/hdm-dim2/dim2_hal.c
> @@ -889,7 +889,7 @@ struct dim_ch_state_t *DIM_GetChannelState(struct dim_channel *ch,
> struct dim_ch_state_t *state_ptr)
> {
> if (!ch || !state_ptr)
> - return 0;
> + return NULL;
>
> state_ptr->ready = ch->state.level < 2;
> state_ptr->done_buffers = ch->done_sw_buffers_number;
This has already been addressed.
Regards,
Chris
next prev parent reply other threads:[~2015-08-19 15:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 10:17 [PATCHv7 0/5] Staging: most: several warnings fix reported by sparse Adrian Remonda
2015-08-14 10:18 ` [PATCHv7 1/5] Staging: most: mostcore/core.c. Fix "missing static keyword" warnings Adrian Remonda
2015-08-19 14:30 ` Christian Gromm
2015-08-14 10:18 ` [PATCHv7 2/5] Staging: most: mostcore/core.c. Fix "Using plain integer as NULL pointer" warnings Adrian Remonda
2015-08-19 14:30 ` Christian Gromm
2015-08-14 10:18 ` [PATCHv7 3/5] Staging: most: hdm-usb/hdm_usb.c. Fix "missing static keyword" warnings Adrian Remonda
2015-08-19 15:06 ` Christian Gromm
2015-08-14 10:18 ` [PATCHv7 4/5] Staging: most: hdm-dim2/dim2_hal.c. Fix "Using plain integer as NULL pointer" warnings Adrian Remonda
2015-08-19 15:12 ` Christian Gromm [this message]
2015-08-14 10:18 ` [PATCHv7 5/5] Staging: most: aim-cdev/cdev.c. Fix "missing static keyword" warnings Adrian Remonda
2015-08-19 15:12 ` Christian Gromm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819171212.295ac863@muaddib \
--to=christian.gromm@microchip.com \
--cc=adrianremonda@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox