From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Michal Suchanek <hramrach@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-crypto@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: un4i-ss-cipher.c warning
Date: Thu, 20 Aug 2015 08:39:00 +0200 [thread overview]
Message-ID: <20150820063900.GJ30520@lukather> (raw)
In-Reply-To: <20150820052903.GA26031@gondor.apana.org.au>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On Thu, Aug 20, 2015 at 01:29:03PM +0800, Herbert Xu wrote:
> On Wed, Aug 19, 2015 at 04:35:36PM +0200, Michal Suchanek wrote:
> > Hello,
> >
> > when building a kernel with sunxi crypto driver as merged into the
> > sinxi-wip branch I get a compiler warning.
> >
> > I am not sure this is the latest version of the driver. It does not
> > seem to be in mainline yet.
>
> The warning appears to be spurious as the code always ends up
> initialising todo before using it.
Not in the dev_dbg call line 258. If ileft was negative or null, todo
isn't assigned to anything.
I'm not sure whether initializing todo to 0 is the right thing to do
though. Corentin?
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-20 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 14:35 un4i-ss-cipher.c warning Michal Suchanek
2015-08-20 5:29 ` Herbert Xu
2015-08-20 6:39 ` Maxime Ripard [this message]
2015-08-20 6:44 ` Herbert Xu
2015-08-20 13:56 ` Corentin LABBE
2015-08-20 22:08 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820063900.GJ30520@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hramrach@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox