From: Dan Carpenter <dan.carpenter@oracle.com>
To: "J. German Rivera" <German.Rivera@freescale.com>
Cc: gregkh@linuxfoundation.org, arnd@arndb.de,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
stuart.yoder@freescale.com, itai.katz@freescale.com,
scottwood@freescale.com, agraf@suse.de, bhamciu1@freescale.com,
R89243@freescale.com, bhupesh.sharma@freescale.com,
nir.erez@freescale.com, richard.schmitt@freescale.com
Subject: Re: [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver
Date: Thu, 20 Aug 2015 10:35:29 +0300 [thread overview]
Message-ID: <20150820073528.GN5610@mwanda> (raw)
In-Reply-To: <1440003160-28717-1-git-send-email-German.Rivera@freescale.com>
On Wed, Aug 19, 2015 at 11:52:40AM -0500, J. German Rivera wrote:
> Since signatures of flib functions have changed, we had to
> change all the corresponding calls in the MC bus driver
>
What does upgrade mean here? I feel like this is the kind of patch we
reject without reading the patch because the description is too vague
and you can tell from the diff stats that it is going to be too huge to
review.
I looked at the first few lines and we are making a ball of changes.
Copyright notices, adding function parameters, renaming functions. This
needs to be explained a lot better and probably split into multiple
patches.
Btw, the trees are closed for the next 3-4 weeks until after 4.3-rc2 is
released.
regards,
dan carpenter
next prev parent reply other threads:[~2015-08-20 7:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 16:52 [PATCH] staging: fsl-mc: Upgraded MC flibs used in MC bus driver J. German Rivera
2015-08-20 7:35 ` Dan Carpenter [this message]
2015-08-25 18:48 ` Jose Rivera
2015-09-03 16:48 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820073528.GN5610@mwanda \
--to=dan.carpenter@oracle.com \
--cc=German.Rivera@freescale.com \
--cc=R89243@freescale.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bhamciu1@freescale.com \
--cc=bhupesh.sharma@freescale.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=itai.katz@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nir.erez@freescale.com \
--cc=richard.schmitt@freescale.com \
--cc=scottwood@freescale.com \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox