From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753895AbbHTPIu (ORCPT ); Thu, 20 Aug 2015 11:08:50 -0400 Received: from down.free-electrons.com ([37.187.137.238]:42101 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752950AbbHTPIs (ORCPT ); Thu, 20 Aug 2015 11:08:48 -0400 Date: Thu, 20 Aug 2015 17:08:45 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Greg Kroah-Hartman , Mark Brown , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Hans de Goede , Meng Zhang , shuge@allwinnertech.com, kevin.z.m.zh@gmail.com Subject: Re: [PATCH v3 1/8] rsb: Add generic Reduced Serial Bus (RSB) controller binding documentation Message-ID: <20150820150845.GB30520@lukather> References: <1439958009-14056-1-git-send-email-wens@csie.org> <1439958009-14056-2-git-send-email-wens@csie.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XoSOsMJQ8mz74oyx" Content-Disposition: inline In-Reply-To: <1439958009-14056-2-git-send-email-wens@csie.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XoSOsMJQ8mz74oyx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Thanks a lot for working on this. On Wed, Aug 19, 2015 at 12:20:02PM +0800, Chen-Yu Tsai wrote: > Reduced Serial Bus is a proprietary 2-line push-pull serial bus > supporting multiple slave devices. >=20 > It was developed by Allwinner, Inc. and used by Allwinner and X-Powers, > Inc. for their line of PMICs and other peripheral ICs. >=20 > Signed-off-by: Chen-Yu Tsai > --- > Documentation/devicetree/bindings/rsb/rsb.txt | 50 +++++++++++++++++++++= ++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rsb/rsb.txt >=20 > diff --git a/Documentation/devicetree/bindings/rsb/rsb.txt b/Documentatio= n/devicetree/bindings/rsb/rsb.txt > new file mode 100644 > index 000000000000..0b027948ca9c > --- /dev/null > +++ b/Documentation/devicetree/bindings/rsb/rsb.txt > @@ -0,0 +1,50 @@ > +Reduced Serial Bus (RSB) Controller > + > +This document defines a generic set of bindings for use by RSB controlle= rs. > +A controller is modelled in device tree as a node with zero or more child > +nodes, each representing a unique slave device on the bus. > + > +Required properties: > + > + - #address-cells : must be 2 > + - #size-cells : must be 0 > + > +Optional properties: > + > + - clock-frequency : Desired bus clock frequency in Hz. Maximum is 20 MH= z. What is the default if not set? > + > +Child nodes: > + > +An RSB controller node can contain zero or more child nodes representing > +slave devices on the bus. Child 'reg' properties are specified as a > +runtime address, hardware address pair. The hardware address is hardwired > +in the device, which can normally be found in the datasheet. The runtime > +address is set by software. No 2 devices on the same bus shall have the > +same runtime address. > + > +Valid runtime addresses - There are only 15 valid runtime addresses: > + > + 0x17, 0x2d, 0x3a, 0x4e, 0x59, 0x63, 0x74, 0x8b, > + 0x9c, 0xa6, 0xb1, 0xc5, 0xd2, 0xe8, 0xff > + > +It is highly recommended that one choose the same runtime addresses as > +vendor BSPs use so that a) the addresses remain the same across different > +software systems, and b) addresses of supported and listed slave devices > +don't conflict with unsupported or not yet listed devices. I'd expect to have the hardware address first, but maybe it's just me :) > +Example: > + > + rsb@... { > + compatible =3D "..."; > + reg =3D <...>; > + /* ... */ > + #address-cells =3D <2>; > + #size-cells =3D <0>; > + > + pmic@2d { The unit-address should be 2d,3e3. > + compatible =3D "..."; > + reg =3D <0x2d 0x3e3>; > + > + /* ... */ > + }; > + }; > --=20 > 2.5.0 >=20 --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --XoSOsMJQ8mz74oyx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV1e19AAoJEBx+YmzsjxAgESUP/jpSCyAeX4bkVgQ34sxRTvxB YYiLC1+B+iKqedQuQU3Hbmu0p8CnV7XMvTNKMVEWIn4AQGh5HQ6ZJZYWd3pHoeU7 gY3qoNqoUSlRDMb57WK7wsTD7Iae2zxMjP4UtyN6FLmDqQI7yG7l9Px1v/ZXyvTE 6E667/Y557CyeYAzRqVLHHfHET1AGYBATLBgHgC47NdPPcj+IYPj/x1cHWkHf0G/ xY12tJ3rH6oiVKh5YvQIswkLTI+VFyAL8gPI0x1N2tt2LWqqa7DDqGHdMSqDfHmh BL4W6krtPw0Wy4doMIRI4WpBuf6h6pLOU+PGwyU/FItLtNvIxxxu8P8UY1txSh+n UOn5HCKYhulC5Ied31Kgj1ybwIvI2ytM23tJqkFbyCGPkyq2gfSLBYtw1UH4AtZu lVVppSJfOmQyrih0sUFUezrrMllcNP1VRnnUh9l9cUaj73kb9sRunds4kcBdNOj+ XP2sEnOI0SyFpAYRWKcjYm1G/wvcla7vdELXwiCJUTF4wPejkiagLnBHF1mBX/Cm Nb/0vIFlR4R1yIfx03m1padrnwREiic03oaAEEXzarCYhzjqeQ8+HRTljkOihwHC YqJ8Ymbe8aaVEkSRWfuZ5OkylKdNEp+DriyGPzs6ryMN63IO3Ibn5+pKtm5Rcn39 iTQLpgVt7MLmRX1SuOvJ =tJRN -----END PGP SIGNATURE----- --XoSOsMJQ8mz74oyx--