Re: [PATCH v3 0/5] sync a se with its cfs_rq when att(det)aching it

Byungchul Park
2015-08-20T10:46:49Z

On Thu, Aug 20, 2015 at 05:38:41PM +0900, Byungchul Park wrote:
> On Thu, Aug 20, 2015 at 03:17:21AM +0200, Peter Zijlstra wrote:
> >
> > I did something like this on top.. please have a look at the XXX and
> > integrate.
>
> i am not sure, what do you intend for me to do.
>
> do you mean that i am supposed to integrate this cleanup patch you gave me
> including the XXX comment?
>
> > + *
> > + * XXX this appears wrong!! check history,
> > + * we appear to always set queued and RUNNING under the same lock instance
> > + * might be from before TASK_WAKING ?
> > */
>
> is it impossible to happen to check if vruntime is normalized, when doing
> something like e.g. active load balance where queued != TASK_ON_RQ_QUEUED
> and p->state == TASK_RUNNING?

furthermore, in any migration by load balance, it seems to be possible..

>
> i think it can happen..
>
> thanks,
> byungchul
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/