From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752968AbbHTVyL (ORCPT ); Thu, 20 Aug 2015 17:54:11 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:33223 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbbHTVyJ (ORCPT ); Thu, 20 Aug 2015 17:54:09 -0400 Date: Thu, 20 Aug 2015 14:54:04 -0700 From: Brian Norris To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Mark Brown , linux-mtd@lists.infradead.org, David Woodhouse Subject: Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information Message-ID: <20150820215404.GA81844@google.com> References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> <1440054451-1223-4-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440054451-1223-4-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 20, 2015 at 09:07:16AM +0200, Javier Martinez Canillas wrote: > The SPI core always reports the MODALIAS uevent as "spi:" > regardless of the mechanism that was used to register the device > (i.e: OF or board code) and the table that is used later to match > the driver with the device (i.e: SPI id table or OF match table). > > So drivers needs to export the SPI id table and this be built into > the module or udev won't have the necessary information to autoload > the needed driver module when the device is added. > > But this means that OF-only drivers needs to have both OF and SPI id > tables that have to be kept in sync and also the dev node compatible > manufacturer prefix is stripped when reporting the MODALIAS. Which can > lead to issues if two vendors use the same SPI device name for example. > > To avoid the above, the SPI core behavior may be changed in the future > to not require an SPI device table for OF-only drivers and report the > OF module alias. So, it's better to also export the OF table even when > is unused now to prevent breaking module loading when the core changes. > > Signed-off-by: Javier Martinez Canillas I appreciate the context for the whole problem here, but this commit subject mostly doesn't apply to this driver, and it deson't seem to match the problem this is solving. As I see it, the patch description for this patch should be more like: "The OF ID table is used for auto-probing the device, but it is not exported to the module device table. That means this driver won't autoload when built as a module. Export the OF ID table to fix that. (insert some reference to the larger issue here)" Do you want to rewrite the message, shall I just prepend my modifications, or am I off-base? > --- > > drivers/mtd/devices/mtd_dataflash.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c > index 0099aba72a8b..df6f61137376 100644 > --- a/drivers/mtd/devices/mtd_dataflash.c > +++ b/drivers/mtd/devices/mtd_dataflash.c > @@ -102,6 +102,7 @@ static const struct of_device_id dataflash_dt_ids[] = { > { .compatible = "atmel,dataflash", }, > { /* sentinel */ } > }; > +MODULE_DEVICE_TABLE(of, dataflash_dt_ids); > #endif > > /* ......................................................................... */ For the patch: Reviewed-by: Brian Norris