Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support

Javi Merino
2015-11-11T09:40:46Z

On Wed, Nov 11, 2015 at 08:27:47AM +0100, Sascha Hauer wrote:
> On Tue, Nov 10, 2015 at 10:26:30AM -0800, Eduardo Valentin wrote:
> > On Tue, Nov 10, 2015 at 12:05:54PM +0000, Javi Merino wrote:
> > > On Mon, Nov 09, 2015 at 11:13:32AM +0100, Sascha Hauer wrote:
> >
> > <cut>
> >
> > > > +
> > > > +/*
> > > > + * The MT8173 thermal controller has four banks. Each bank can read up to
> > > > + * four temperature sensors simultaneously. The MT8173 has a total of 5
> > > > + * temperature sensors. We use each bank to measure a certain area of the
> > > > + * SoC. Since TS2 is located centrally in the SoC it is influenced by multiple
> > > > + * areas, hence is used in different banks.
> > > > + */
> > > > +static const struct mtk_thermal_bank_cfg bank_data[] = {
> > > > + {
> > > > + .num_sensors = 2,
> > > > + .sensors = { MT8173_TS2, MT8173_TS3 },
> > > > + }, {
> > > > + .num_sensors = 2,
> > > > + .sensors = { MT8173_TS2, MT8173_TS4 },
> > > > + }, {
> > > > + .num_sensors = 3,
> > > > + .sensors = { MT8173_TS1, MT8173_TS2, MT8173_TSABB },
> > > > + }, {
> > > > + .num_sensors = 1,
> > > > + .sensors = { MT8173_TS2 },
> > > > + },
> > > > +};
> >
> > Would it make sense to simply expose all sensors and let the
> > configuration of their aggregation be done by DT?
>
> This particular layout has been chosen because there's also the Smart
> Voltage Scaler (SVS) in the SoC. The SVS uses the same banks for
> measuring temperatures. I don't know the details yet, I just asked the
> Mediatek guys.
>
> >
> > There is already ongoing effort to get aggregation functions
> > generalized.
>
> Do you have any pointers? I haven't seen these efforts yet.

Hierarchical thermal zones
http://thread.gmane.org/gmane.linux.power-management.general/67785

You could keep your thermal zones per bank and then use the
hierarchical thermal zone to create a thermal zone that calculates the
maximum of all banks. You can put the trip points in this thermal
zone.

> > > > +static int mtk_read_temp(void *data, int *temperature)
> > > > +{
> > > > + struct mtk_thermal *mt = data;
> > > > + int i;
> > > > + int tempmax = INT_MIN;
> > > > +
> > > > + for (i = 0; i < MT8173_NUM_ZONES; i++) {
> > > > + struct mtk_thermal_bank *bank = &mt->banks[i];
> > > > + int t;
> > > > +
> > > > + mtk_thermal_get_bank(bank);
> > > > +
> > > > + t = mtk_thermal_bank_temperature(bank);
> > >
> > > IIUIC, when you had multiple thermal zones
> > > mtk_thermal_bank_temperature() made sense, but now it looks like
> > > you're just doing the maximum of all sensors. Why bother with the
> > > banks any more? Aren't you just calculating the maximum of all
> > > sensors? As TS2 is present in all banks, there's no point in reading
> > > it four times just to get the maximum of all sensors.
> > >
> >
> > Yeah, agreed here. If that is your intention, maybe read each sensor one
> > time, then compute the max of each subset from memory instead.
>
> I would have done that if there wasn't this SVS engine. I'll ask
> internally what the constraint of this SVS engine actually are and let
> you know.
>
> Sascha
>
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>