From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752879AbbHTW3R (ORCPT ); Thu, 20 Aug 2015 18:29:17 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:34282 "EHLO mail-io0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105AbbHTW3P (ORCPT ); Thu, 20 Aug 2015 18:29:15 -0400 Date: Thu, 20 Aug 2015 17:29:09 -0500 From: Michael Welling To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Andrea Galbusera , linux-iio@vger.kernel.org, Peter Meerwald , Lars-Peter Clausen , Manfred Schlaegl , =?iso-8859-1?Q?S=F8ren?= Andersen , Jonathan Cameron , Hartmut Knaack Subject: Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table Message-ID: <20150820222906.GB28249@deathstar> References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> <1440054451-1223-14-git-send-email-javier@osg.samsung.com> <20150820200912.GA2866@deathstar> <55D64E80.4050502@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55D64E80.4050502@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: > Hello Michael, > > On 08/20/2015 10:09 PM, Michael Welling wrote: > > On Thu, Aug 20, 2015 at 09:07:26AM +0200, Javier Martinez Canillas wrote: > >> The driver has an OF id table but the .of_match_table is not set so > >> the SPI core can't do an OF style match and the table was unused. > >> > > > > Is an OF style match necessary? > > > > Did you read the cover letter [0] on which I explain why is needed to > avoid breaking module autoloading in the future? Once the SPI core is > changed by RFC patch 18/18? (you were cc'ed in the cover letter BTW). Well I have read it now. :) > > > I have been using devicetree and it matches based on the .id_table. > > > > Yes it fallbacks to the .id_table or the driver name but the correct > thing to do for devices registered by OF, is to match using the > compatible string. > > > Couldn't we just remove the mcp320x_dt_ids table instead? > > > > No, that is the wrong thing to do IMHO since the compatible string > contains both vendor and device name whle the .id_table only contains > a device name. > > So it makes sense to match using the compatible string and also report > the OF modalias information to user-space. > > Otherwise what's the point of the vendor in the compatible string for > SPI devices? You can just use "bar" instead of "foo,bar" as a string. > Well then shouldn't the patch include adding the vendor to the compatible string? > [0]: https://lkml.org/lkml/2015/8/20/109 > > Best regards, > -- > Javier Martinez Canillas > Open Source Group > Samsung Research America