From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752925AbbHTWeq (ORCPT ); Thu, 20 Aug 2015 18:34:46 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:33095 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbbHTWep (ORCPT ); Thu, 20 Aug 2015 18:34:45 -0400 Date: Thu, 20 Aug 2015 15:34:40 -0700 From: Brian Norris To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Mark Brown , linux-mtd@lists.infradead.org, David Woodhouse Subject: Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information Message-ID: <20150820223440.GC81844@google.com> References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> <1440054451-1223-4-git-send-email-javier@osg.samsung.com> <20150820215404.GA81844@google.com> <55D6510E.7010002@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55D6510E.7010002@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2015 at 12:13:34AM +0200, Javier Martinez Canillas wrote: > So this patch really is a no-op right now and is not fixing anything. > As long as the driver has a MODULE_DEVICE_TABLE(spi,...), things will This driver does not have a MODULE_DEVICE_TABLE() at all, nor does it use spi_device_id. So, it is currently broken for the module use case. > work without a MODULE_DEVICE_TABLE(of,...). Brian