From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, a.zummo@towertech.it,
cw00.choi@samsung.com, k.kozlowski@samsung.com
Subject: Re: [PATCH 1/4] rtc: s3c: add missing clk control
Date: Fri, 21 Aug 2015 01:06:50 +0200 [thread overview]
Message-ID: <20150820230650.GC3769@piout.net> (raw)
In-Reply-To: <1439292502-22912-1-git-send-email-jy0922.shim@samsung.com>
On 11/08/2015 at 20:28:19 +0900, Joonyoung Shim wrote :
> It's missed to call clk_unprepare() about info->rtc_src_clk in
> s3c_rtc_remove and to call clk_disable_unprepare about info->rtc_clk in
> error routine of s3c_rtc_probe.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> drivers/rtc/rtc-s3c.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-08-20 23:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 11:28 [PATCH 1/4] rtc: s3c: add missing clk control Joonyoung Shim
2015-08-11 11:28 ` [PATCH 2/4] rtc: s3c: remove unnecessary NULL assignment Joonyoung Shim
2015-08-12 0:07 ` Krzysztof Kozlowski
2015-08-20 23:07 ` Alexandre Belloni
2015-08-11 11:28 ` [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk Joonyoung Shim
2015-08-12 0:10 ` Krzysztof Kozlowski
2015-08-12 10:26 ` Joonyoung Shim
2015-08-11 11:28 ` [PATCH 4/4] rtc: s3c: enable/disable clocks for alarm Joonyoung Shim
2015-08-12 0:28 ` Krzysztof Kozlowski
2015-08-12 1:09 ` Joonyoung Shim
2015-08-12 0:06 ` [PATCH 1/4] rtc: s3c: add missing clk control Krzysztof Kozlowski
2015-08-20 23:06 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150820230650.GC3769@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=cw00.choi@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox