From: Vinod Koul <vinod.koul@intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: CONFIG_OF vs DMA_OF
Date: Fri, 21 Aug 2015 13:56:36 +0530 [thread overview]
Message-ID: <20150821082636.GK13546@localhost> (raw)
In-Reply-To: <87wpwpurzk.wl%kuninori.morimoto.gx@renesas.com>
On Fri, Aug 21, 2015 at 05:35:58AM +0000, Kuninori Morimoto wrote:
>
> Hi Vinod
>
> ${LINUX}/drivers/dma/of-dma.c will be compiled if .config has DMA_OF
>
> obj-$(CONFIG_DMA_OF) += of-dma.o
>
> But, ${LINUX}/include/linux/of_dma.h is based on CONFIG_OF
Intially it was OF only and then DMA_OF was added. I think we missed it
during the move, so yes your below patch makes sense
Can you please send as formal patch for me to apply
--
~Vinod
>
> #ifdef CONFIG_OF
> extern int of_dma_controller_register(struct device_node *np,
> ...
> #else
> static inline int of_dma_controller_register(struct device_node *np,
> ...
> #endif
>
> I have issue if .config has CONFIG_OF but not have DMA_OF.
> Is this correct patch ?
>
> ---------------------------------
> diff --git a/include/linux/of_dma.h b/include/linux/of_dma.h
> index 98ba752..9440622 100644
> --- a/include/linux/of_dma.h
> +++ b/include/linux/of_dma.h
> @@ -34,7 +34,7 @@ struct of_dma_filter_info {
> dma_filter_fn filter_fn;
> };
>
> -#ifdef CONFIG_OF
> +#ifdef DMA_OF
> extern int of_dma_controller_register(struct device_node *np,
> struct dma_chan *(*of_dma_xlate)
> (struct of_phandle_args *, struct of_dma *),
> ---------------------------------
>
>
> Best regards
> ---
> Kuninori Morimoto
--
--
~Vinod
next prev parent reply other threads:[~2015-08-21 8:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 5:35 CONFIG_OF vs DMA_OF Kuninori Morimoto
2015-08-21 8:26 ` Vinod Koul [this message]
2015-08-21 11:47 ` [PATCH 0/2] " Kuninori Morimoto
2015-08-21 11:48 ` [PATCH 1/2] dmaengine: OF DMAEngine API based on CONFIG_DMA_OF instead of CONFIG_OF Kuninori Morimoto
2015-08-24 9:19 ` Vinod Koul
2015-08-25 0:15 ` Kuninori Morimoto
2015-09-10 8:26 ` [alsa-devel] " Kuninori Morimoto
2015-09-16 1:37 ` Kuninori Morimoto
2015-09-28 8:43 ` Kuninori Morimoto
2015-10-01 2:10 ` Vinod Koul
2015-10-02 0:33 ` Kuninori Morimoto
2015-08-21 11:49 ` [PATCH 2/2] ASoC: rsnd: SND_SOC_RCAR doesn't depend on DMA_OF Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821082636.GK13546@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).