public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho dn Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Dean Nelson <dnelson@redhat.com>,
	a.p.zijlstra@chello.org, mingo@redhat.com, rostedt@goodmis.org,
	namhyung@kernel.org, linux-kernel@vger.kernel.org,
	jolsa@kernel.org
Subject: Re: [PATCH v3] tools lib traceevent: add checks for returned EVENT_ERROR type
Date: Fri, 21 Aug 2015 10:34:41 -0300	[thread overview]
Message-ID: <20150821133441.GE3154@kernel.org> (raw)
In-Reply-To: <20150820151632.13927.13791.email-sent-by-dnelson@teal>

Em Thu, Aug 20, 2015 at 11:16:32AM -0400, Dean Nelson escreveu:
> Running the following perf-stat command on an arm64 system produces the
> following result...
 
>   [root@aarch64 ~]# perf stat -e kmem:mm_page_alloc -a sleep 1
>     Warning: [kmem:mm_page_alloc] function sizeof not defined
>     Warning: Error: expected type 4 but read 0
>   Segmentation fault
>   [root@aarch64 ~]#

Jiri, while testing this I noticed that when running as !root I get:

  $ perf stat -e kmem:mm_page_alloc -a sleep 1
  event syntax error: 'kmem:mm_page_alloc'
                       \___ unknown tracepoint
  Run 'perf list' for a list of valid events

 usage: perf stat [<options>] [<command>]

      -e, --event <event>   event selector. use 'perf list' to list available events
  [acme@zoo linux]$ 

Which could be a bit more friendly if it noticed that it may be a
tracepoint event and that if that is the case, the user needs to have
tracefs remounted with suitable permissions to be able to use
tracepoints, something like 'perf trace' does:

  [acme@zoo linux]$ trace ls
  Error:	No permissions to read
  /sys/kernel/debug/tracing/events/raw_syscalls/sys_(enter|exit)
  Hint:	Try 'sudo mount -o remount,mode=755 /sys/kernel/debug'

  [acme@zoo linux]$

Take that as a suggestion as you're more familiar with the event parsing
code :-)

- Arnaldo

  parent reply	other threads:[~2015-08-21 13:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20 15:16 [PATCH v3] tools lib traceevent: add checks for returned EVENT_ERROR type Dean Nelson
2015-08-20 15:57 ` Namhyung Kim
2015-08-20 17:05 ` Steven Rostedt
2015-08-20 17:56   ` Dean Nelson
2015-08-20 19:05     ` Arnaldo Carvalho de Melo
2015-08-20 20:43       ` Steven Rostedt
2015-08-21 13:34 ` Arnaldo Carvalho dn Melo [this message]
2015-08-21 14:03   ` Jiri Olsa
2015-08-22  6:52 ` [tip:perf/core] tools lib traceevent: Add " tip-bot for Dean Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150821133441.GE3154@kernel.org \
    --to=acme@kernel.org \
    --cc=a.p.zijlstra@chello.org \
    --cc=dnelson@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox