From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Laura Abbott <labbott@fedoraproject.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCHv2] Input: xpad - Fix double URB submission races
Date: Fri, 21 Aug 2015 09:50:58 -0700 [thread overview]
Message-ID: <20150821165058.GG26302@localhost> (raw)
In-Reply-To: <1439252772-28482-1-git-send-email-labbott@fedoraproject.org>
Hi Laura,
On Mon, Aug 10, 2015 at 05:26:12PM -0700, Laura Abbott wrote:
> v2: Created a proper queue for events instead of just dropping them
How long does it take for the queue to exhaust your memory if you keep
bombarding the driver with requests?
I do not think you need a queue. I believe the nature of LEDs and rumble
force feedback effect is such that you can discard all requests but the
latest that arrived between the moment you submitted a request to the
device and the moment you are ready submit a new one.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2015-08-21 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-11 0:26 [PATCHv2] Input: xpad - Fix double URB submission races Laura Abbott
2015-08-21 16:50 ` Dmitry Torokhov [this message]
2015-08-25 4:22 ` Laura Abbott
2015-08-26 17:19 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150821165058.GG26302@localhost \
--to=dmitry.torokhov@gmail.com \
--cc=labbott@fedoraproject.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox