From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbbHURM4 (ORCPT ); Fri, 21 Aug 2015 13:12:56 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34832 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751585AbbHURMy (ORCPT ); Fri, 21 Aug 2015 13:12:54 -0400 Date: Fri, 21 Aug 2015 10:03:53 -0700 From: Olof Johansson To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Gwendal Grignou , Doug Anderson , Bartlomiej Zolnierkiewicz , Wolfram Sang , Dmitry Torokhov , Lee Jones , Geert Uytterhoeven Subject: Re: [PATCH 3/6] platform/chrome: Make depends on MFD_CROS_EC instead CROS_EC_PROTO Message-ID: <20150821170353.GB26236@localhost> References: <1439983198-4696-1-git-send-email-javier@osg.samsung.com> <1439983198-4696-4-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439983198-4696-4-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2015 at 01:19:55PM +0200, Javier Martinez Canillas wrote: > The ChromeOS EC LPC and chardev drivers depend on CROS_EC_PROTO but > MFD_CROS_EC select CROS_EC_PROTO instead. Mixing select and depends > on is bad practice as it may lead to circular Kconfig dependencies. > > Since the platform devices that are matched with these drivers are > registered by the ChromeOS EC mfd driver, they really depend on > MFD_CROS_EC. And because this config option selects CROS_EC_PROTO, > that dependency is met as well. So make the drivers to depend on > MFD_CROS_EC instead of CROS_EC_PROTO. > > Signed-off-by: Javier Martinez Canillas Applied, thanks.