From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752764AbbHUUPj (ORCPT ); Fri, 21 Aug 2015 16:15:39 -0400 Received: from e24smtp01.br.ibm.com ([32.104.18.85]:39049 "EHLO e24smtp01.br.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375AbbHUUPh (ORCPT ); Fri, 21 Aug 2015 16:15:37 -0400 X-Helo: d24dlp01.br.ibm.com X-MailFrom: leosilva@linux.vnet.ibm.com X-RcptTo: linux-next@vger.kernel.org Date: Fri, 21 Aug 2015 17:15:24 -0300 From: Leonidas S Barbosa To: Paul Gortmaker Cc: linux-crypto@vger.kernel.org, Herbert Xu , LKML , Paulo Smorigo , "David S. Miller" , "linux-next@vger.kernel.org" Subject: Re: [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug Message-ID: <20150821201522.GA18207@bluepex.com> References: <20150814131218.GA11746@bluepex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15082120-1524-0000-0000-00000368ABDF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2015 at 03:19:18PM -0400, Paul Gortmaker wrote: > On Fri, Aug 14, 2015 at 9:12 AM, Leonidas S Barbosa > wrote: > > AES-CTR is using a counter 8bytes-8bytes what miss match with > > kernel specs. > > > > In the previous code a vadduwm was done to increment counter. > > Replacing this for a vadduqm now considering both cases counter > > 8-8 bytes and full 16bytes. > > Seems this breaks ppc allmodconfig: > > drivers/crypto/vmx/aesp8-ppc.S:1545: Error: Unrecognized opcode: `vadduqm' Thanks for report, I could not reproduce this issue, but I believe it's a opcode map error on ppc-xlate.pl. Sending a patch followed by this email you CCed.