From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752867AbbHUUWy (ORCPT ); Fri, 21 Aug 2015 16:22:54 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:42977 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752153AbbHUUWx (ORCPT ); Fri, 21 Aug 2015 16:22:53 -0400 Date: Fri, 21 Aug 2015 15:22:44 -0500 From: Felipe Balbi To: Felipe Balbi CC: Robert Baldyga , , , , Subject: Re: [PATCH] usb: gadget: fix possible regression introduced with ep->claimed Message-ID: <20150821202244.GD31631@saruman.tx.rr.com> Reply-To: References: <1440147689-1157-1-git-send-email-r.baldyga@samsung.com> <20150821150050.GB527@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HWvPVVuAAfuRc6SZ" Content-Disposition: inline In-Reply-To: <20150821150050.GB527@saruman.tx.rr.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HWvPVVuAAfuRc6SZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Aug 21, 2015 at 10:00:50AM -0500, Felipe Balbi wrote: > On Fri, Aug 21, 2015 at 11:01:29AM +0200, Robert Baldyga wrote: > > This patch fixes possible regression introduced by patch reworking endp= oint > > claiming mechanism. It restores setring ep->driver_data to NULL in > > usb_ep_autoconfig_reset(), which was removed by patch [1]. > >=20 > > [1] commit cc476b42a39d ("usb: gadget: encapsulate endpoint claiming > > mechanism") > >=20 > > Reported-by: Felipe Balbi > > Signed-off-by: Robert Baldyga > > --- > >=20 > > Hi Felipe, > >=20 > > I was not able to reproduce the problem that you have described (functi= ons > > trying to enable eps that are already enabled, and disable eps that are > > already disabled), but I have analysed the problem and I have concluded >=20 > it happens with all, you can't see it because dwc3 (only) has a WARN() > for when an endpoint is enabled and has previously been enabled > (drivers/usb/dwc3/gadget.c). If you track your endpoint's state > regarding being enabled or not, you can add a WARN() to see the error. >=20 > > that the only possible cause of regression can be that my patch removed > > setting ep->driver_data to NULL in usb_ep_autoconfig_reset() function. > > Because of this change initial state of ep->driver_data could be non-NU= LL > > value, which could change behavoiur of some functions. I can't imagine > > any other possible cause of regression introduced by such simple patch. >=20 > yeah, I'll test this later. this has been running for many hours and I couldn't find any problems so far. Just in case, I'll keep it running, but I doubt we'll find anything. Once -rc1 is tagged, I'll send this to Greg. thanks --=20 balbi --HWvPVVuAAfuRc6SZ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV14iUAAoJEIaOsuA1yqREaecQAKEtO+L7WtPryVeXGpYBIws3 Tk9wg2aDyjtqi25WiUCbNBK6ydhspUeCiOhjcVAH9gHn07dyfm0QTOFp4pgJrFbk elqzbCmub1KdzJgpeHbMRlJUA1cEPUzSTLABs7juZnP+/MzNb8+6Vgj+khA/MhkS LUg/gHVx0FBwCptBkAMHxdcmOInCBm45ZCkE0pK6ZFW1et3cvesBOdYuTKp2Cany 2ljql3lbXS15wdmbJT90PIgk9OwsoD+Die0oDPJU+OA30PnllKNJ5MB+WVxl7SXc Z+IwiOlGB8E/rLQT5y2iMlIc0/Nk5KQmO4UPhavUa8y1pZUPs+vSBu3jo+zmHp+8 oM/rvzLAeWwhayEFiUIK4xdrYPsY2J+77TbA2QnPywnATiwnBwIvkPFI1MGL5P+q fT4G8dTWinjTeUpNSIhHJxWEx9s3HijhIYHSMG0VUNvw+0pd21ExMTd7x+td9+Co L4fOMC8mAysBF3qx06l/iiv4YLRlh5EbiTV0eXninKCfCpBbJvk8HPXWRfhvodHT S1qO9iA7F82GlV723kmxPSSG8O31Msb1ygpYKaIq+Z+yaN5eKBf1CXlo905Uq7k0 LbbdlfbaSWY+DpzlDufdS/MelsLtfuLgaYve9mis02qMsBAs/A22xByS3iFRVgVd ZU0r0bvRHjYcYqQyNWGZ =UZYf -----END PGP SIGNATURE----- --HWvPVVuAAfuRc6SZ--