From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752601AbbHUWrT (ORCPT ); Fri, 21 Aug 2015 18:47:19 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:36036 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752400AbbHUWrS (ORCPT ); Fri, 21 Aug 2015 18:47:18 -0400 Date: Fri, 21 Aug 2015 15:47:14 -0700 From: Brian Norris To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Mark Brown , linux-mtd@lists.infradead.org, David Woodhouse Subject: Re: [PATCH 03/18] mtd: dataflash: Export OF module alias information Message-ID: <20150821224714.GD81844@google.com> References: <1440054451-1223-1-git-send-email-javier@osg.samsung.com> <1440054451-1223-4-git-send-email-javier@osg.samsung.com> <20150820215404.GA81844@google.com> <55D6510E.7010002@osg.samsung.com> <20150820223440.GC81844@google.com> <55D65B72.2050006@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55D65B72.2050006@osg.samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On Fri, Aug 21, 2015 at 12:57:54AM +0200, Javier Martinez Canillas wrote: > On 08/21/2015 12:34 AM, Brian Norris wrote: > > On Fri, Aug 21, 2015 at 12:13:34AM +0200, Javier Martinez Canillas wrote: > >> So this patch really is a no-op right now and is not fixing anything. > >> As long as the driver has a MODULE_DEVICE_TABLE(spi,...), things will > > > > This driver does not have a MODULE_DEVICE_TABLE() at all, nor does it > > use spi_device_id. So, it is currently broken for the module use case. > > > > That is correct but also that does not mean that this patch will fix > module autoloading right now. It will though once the SPI core is > changed to report a OF type module alias. Ah, thanks for the patience. I missed the point that it will still be broken. > So what about something along this lines? > > mtd: dataflash: Export OF module alias information > > The SPI core currently reports the MODALIAS uevent as "spi:" > even for SPI devices that were registered by OF. > > That means the OF module alias exported by MODULE_OF_TABLE(of,...) is > currently not used and user-space has no way to autoload this module. > > But is still a good practice to add the OF module alias information nit: s/is/it is/ > into the kernel module even when currently is unused so once the SPI ditto > core is changed to report a correct OF modalias uevent, module > autoloading will be working for this driver. Otherwise, looks good. I'll either patch in this commit message, or await v2. Your call. Regards, Brian