From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753359AbbHVIOK (ORCPT ); Sat, 22 Aug 2015 04:14:10 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:35852 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbbHVIOF (ORCPT ); Sat, 22 Aug 2015 04:14:05 -0400 Date: Sat, 22 Aug 2015 10:13:59 +0200 From: Ingo Molnar To: Denys Vlasenko Cc: Borislav Petkov , "H. Peter Anvin" , Andy Lutomirski , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns Message-ID: <20150822081359.GA10490@gmail.com> References: <1440152395-19818-1-git-send-email-dvlasenk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440152395-19818-1-git-send-email-dvlasenk@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Denys Vlasenko wrote: > Only compile-tested. > > Signed-off-by: Denys Vlasenko > CC: Ingo Molnar > CC: Borislav Petkov > CC: "H. Peter Anvin" > CC: Andy Lutomirski > CC: Kees Cook > CC: x86@kernel.org > CC: linux-kernel@vger.kernel.org > --- > arch/x86/math-emu/fpu_aux.c | 70 ++++++++++++++++++++++ > arch/x86/math-emu/fpu_entry.c | 14 +++-- > arch/x86/math-emu/fpu_proto.h | 12 ++++ > arch/x86/math-emu/reg_compare.c | 128 ++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 218 insertions(+), 6 deletions(-) Very nice! I tried out this patch (had to fix two math-emu bugs first), but it does not seem to make any difference, I still get a SIGILL in FUCOMIP: 4dd76371: df e9 fucomip %st(1),%st Thanks, Ingo