From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753179AbbHVNvI (ORCPT ); Sat, 22 Aug 2015 09:51:08 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37572 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbbHVNvG (ORCPT ); Sat, 22 Aug 2015 09:51:06 -0400 Date: Sat, 22 Aug 2015 15:51:01 +0200 From: Ingo Molnar To: Peter Zijlstra Cc: Alexander Shishkin , Ingo Molnar , linux-kernel@vger.kernel.org, adrian.hunter@intel.com, Arnaldo Carvalho de Melo , Vince Weaver , Stephane Eranian Subject: Re: [PATCH RFC v1 0/4] perf: Introduce extended syscall error reporting Message-ID: <20150822135101.GA7688@gmail.com> References: <1437738359-23920-1-git-send-email-alexander.shishkin@linux.intel.com> <20150805170100.GP19282@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150805170100.GP19282@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Peter Zijlstra wrote: > On Fri, Jul 24, 2015 at 02:45:55PM +0300, Alexander Shishkin wrote: > > Hi Peter and Ingo and everybody, > > > > Here's my second stab at improving perf's error reporting by attaching > > arbitrary strings to the integer error codes. This is largely based > > off of the previous email thread [1]. > > > > This time around, I employed a linker trick to convert the structures > > containing extended error information into integers, which are then > > made to look just like normal error codes so that IS_ERR_VALUE() and > > friends would still work correctly on them. So no extra pointers in > > the struct perf_event or anywhere else; the extended error codes are > > passed around like normal error codes. They only need to be converted > > in syscalls' topmost return statements. This is done in 1/4. > > > > Then, 2/4 illustrates how error sites can be extended to include more > > information such as file names and line numbers [1]. > > > > The other two patches add perf_err() annotation to a few semi-randomly > > picked places in perf core (3/4) and x86 bits (4/4). > > Looks generally ok to me. Thanks for doing this. I like this too. Alexander, mind sending a finalized, signed off version? Thanks, Ingo