public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Huacai Chen <chenhc@lemote.com>,
	linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: mips: Fix console output for Fulong2e system
Date: Sat, 22 Aug 2015 14:34:34 -0700	[thread overview]
Message-ID: <20150822213434.GA14985@roeck-us.net> (raw)
In-Reply-To: <1438927036-1435-1-git-send-email-linux@roeck-us.net>

On Thu, Aug 06, 2015 at 10:57:16PM -0700, Guenter Roeck wrote:
> Commit 3adeb2566b9b ("MIPS: Loongson: Improve LEFI firmware interface")
> made the number of UARTs dynamic if LEFI_FIRMWARE_INTERFACE is configured.
> Unfortunately, it did not initialize the number of UARTs if
> LEFI_FIRMWARE_INTERFACE is not configured. As a result, the Fulong2e
> system has no console.
> 
> Fixes: 3adeb2566b9b ("MIPS: Loongson: Improve LEFI firmware interface")
> Cc: Huacai Chen <chenhc@lemote.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Hello Ralf,

please let me know if anything is wrong with this patch.
Should I resend with Huacai Chen's Ack and capital MIPS in the subject line ?

Thanks,
Guenter

> ---
> Never mind my earlier e-mail, I figured it out.
> Should be a candidate for stable (v3.19+, ie v4.1 in practice).
> 
>  arch/mips/loongson64/common/env.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/mips/loongson64/common/env.c b/arch/mips/loongson64/common/env.c
> index f6c44dd332e2..d6d07ad56180 100644
> --- a/arch/mips/loongson64/common/env.c
> +++ b/arch/mips/loongson64/common/env.c
> @@ -64,6 +64,9 @@ void __init prom_init_env(void)
>  	}
>  	if (memsize == 0)
>  		memsize = 256;
> +
> +	loongson_sysconf.nr_uarts = 1;
> +
>  	pr_info("memsize=%u, highmemsize=%u\n", memsize, highmemsize);
>  #else
>  	struct boot_params *boot_p;

      parent reply	other threads:[~2015-08-22 21:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07  5:57 [PATCH] mips: Fix console output for Fulong2e system Guenter Roeck
2015-08-07  6:12 ` 陈华才
2015-08-22 21:34 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150822213434.GA14985@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=chenhc@lemote.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox