From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823AbbHVVep (ORCPT ); Sat, 22 Aug 2015 17:34:45 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:33544 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750824AbbHVVeo (ORCPT ); Sat, 22 Aug 2015 17:34:44 -0400 Date: Sat, 22 Aug 2015 14:34:34 -0700 From: Guenter Roeck To: Ralf Baechle Cc: Huacai Chen , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: mips: Fix console output for Fulong2e system Message-ID: <20150822213434.GA14985@roeck-us.net> References: <1438927036-1435-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438927036-1435-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 06, 2015 at 10:57:16PM -0700, Guenter Roeck wrote: > Commit 3adeb2566b9b ("MIPS: Loongson: Improve LEFI firmware interface") > made the number of UARTs dynamic if LEFI_FIRMWARE_INTERFACE is configured. > Unfortunately, it did not initialize the number of UARTs if > LEFI_FIRMWARE_INTERFACE is not configured. As a result, the Fulong2e > system has no console. > > Fixes: 3adeb2566b9b ("MIPS: Loongson: Improve LEFI firmware interface") > Cc: Huacai Chen > Signed-off-by: Guenter Roeck Hello Ralf, please let me know if anything is wrong with this patch. Should I resend with Huacai Chen's Ack and capital MIPS in the subject line ? Thanks, Guenter > --- > Never mind my earlier e-mail, I figured it out. > Should be a candidate for stable (v3.19+, ie v4.1 in practice). > > arch/mips/loongson64/common/env.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/mips/loongson64/common/env.c b/arch/mips/loongson64/common/env.c > index f6c44dd332e2..d6d07ad56180 100644 > --- a/arch/mips/loongson64/common/env.c > +++ b/arch/mips/loongson64/common/env.c > @@ -64,6 +64,9 @@ void __init prom_init_env(void) > } > if (memsize == 0) > memsize = 256; > + > + loongson_sysconf.nr_uarts = 1; > + > pr_info("memsize=%u, highmemsize=%u\n", memsize, highmemsize); > #else > struct boot_params *boot_p;