* [PATCH] staging: fbtft: Made into two lines
@ 2015-08-21 13:08 Aparna Karuthodi
2015-08-23 7:52 ` Giedrius Statkevičius
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Aparna Karuthodi @ 2015-08-21 13:08 UTC (permalink / raw)
To: gregkh; +Cc: thomas.petazzoni, noralf, linux-kernel, devel, Aparna Karuthodi
Made the comment into a new lineto remove a coding style error detected
by checkpatch.
The warning is given below:
drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters
Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
drivers/staging/fbtft/fb_pcd8544.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
index 8b9ebfb..cf87ce8 100644
--- a/drivers/staging/fbtft/fb_pcd8544.c
+++ b/drivers/staging/fbtft/fb_pcd8544.c
@@ -34,7 +34,8 @@
#define WIDTH 84
#define HEIGHT 48
#define TXBUFLEN (84*6)
-#define DEFAULT_GAMMA "40" /* gamma is used to control contrast in this driver */
+#define DEFAULT_GAMMA "40"
+/* gamma is used to control contrast in this driver */
static unsigned tc;
module_param(tc, uint, 0);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: fbtft: Made into two lines
2015-08-21 13:08 [PATCH] staging: fbtft: Made into two lines Aparna Karuthodi
@ 2015-08-23 7:52 ` Giedrius Statkevičius
2015-08-23 13:30 ` Aparna Karuthodi
2015-08-24 13:11 ` Sudip Mukherjee
2 siblings, 0 replies; 6+ messages in thread
From: Giedrius Statkevičius @ 2015-08-23 7:52 UTC (permalink / raw)
To: Aparna Karuthodi; +Cc: gregkh, devel, noralf, linux-kernel
On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote:
> Made the comment into a new lineto remove a coding style error detected
> by checkpatch.
> The warning is given below:
> drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters
>
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
> drivers/staging/fbtft/fb_pcd8544.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index 8b9ebfb..cf87ce8 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -34,7 +34,8 @@
> #define WIDTH 84
> #define HEIGHT 48
> #define TXBUFLEN (84*6)
> -#define DEFAULT_GAMMA "40" /* gamma is used to control contrast in this driver */
> +#define DEFAULT_GAMMA "40"
> +/* gamma is used to control contrast in this driver */
I think the format is usually:
/* comment */
#define FOO BAR
>
> static unsigned tc;
> module_param(tc, uint, 0);
> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: fbtft: Made into two lines
2015-08-21 13:08 [PATCH] staging: fbtft: Made into two lines Aparna Karuthodi
2015-08-23 7:52 ` Giedrius Statkevičius
@ 2015-08-23 13:30 ` Aparna Karuthodi
2015-08-24 19:08 ` Giedrius Statkevičius
2015-08-24 19:33 ` Giedrius Statkevičius
2015-08-24 13:11 ` Sudip Mukherjee
2 siblings, 2 replies; 6+ messages in thread
From: Aparna Karuthodi @ 2015-08-23 13:30 UTC (permalink / raw)
To: gregkh; +Cc: thomas.petazzoni, noralf, linux-kernel, devel, Aparna Karuthodi
Oh! Sorry! I made the changes to correct the faults you figured out.
Is it okay now?
Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
---
drivers/staging/fbtft/fb_pcd8544.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
index cf87ce8..925511f 100644
--- a/drivers/staging/fbtft/fb_pcd8544.c
+++ b/drivers/staging/fbtft/fb_pcd8544.c
@@ -34,8 +34,8 @@
#define WIDTH 84
#define HEIGHT 48
#define TXBUFLEN (84*6)
-#define DEFAULT_GAMMA "40"
/* gamma is used to control contrast in this driver */
+#define DEFAULT_GAMMA "40"
static unsigned tc;
module_param(tc, uint, 0);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: fbtft: Made into two lines
2015-08-23 13:30 ` Aparna Karuthodi
@ 2015-08-24 19:08 ` Giedrius Statkevičius
2015-08-24 19:33 ` Giedrius Statkevičius
1 sibling, 0 replies; 6+ messages in thread
From: Giedrius Statkevičius @ 2015-08-24 19:08 UTC (permalink / raw)
To: Aparna Karuthodi; +Cc: gregkh, devel, noralf, linux-kernel
On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote:
> Oh! Sorry! I made the changes to correct the faults you figured out.
> Is it okay now?
Resubmit it properly with "PATCH v2" in the title and a good commit message.
>
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
> drivers/staging/fbtft/fb_pcd8544.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index cf87ce8..925511f 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -34,8 +34,8 @@
> #define WIDTH 84
> #define HEIGHT 48
> #define TXBUFLEN (84*6)
> -#define DEFAULT_GAMMA "40"
> /* gamma is used to control contrast in this driver */
Isn't this comment supposed to be on the previous line (the removed line)?
Check if you haven't messed this up
> +#define DEFAULT_GAMMA "40"
>
> static unsigned tc;
> module_param(tc, uint, 0);
> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: fbtft: Made into two lines
2015-08-23 13:30 ` Aparna Karuthodi
2015-08-24 19:08 ` Giedrius Statkevičius
@ 2015-08-24 19:33 ` Giedrius Statkevičius
1 sibling, 0 replies; 6+ messages in thread
From: Giedrius Statkevičius @ 2015-08-24 19:33 UTC (permalink / raw)
To: Aparna Karuthodi; +Cc: gregkh, devel, noralf, linux-kernel
On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote:
> Oh! Sorry! I made the changes to correct the faults you figured out.
> Is it okay now?
Better. Also, submit it again with proper commit message and put "PATCH v2" in
the subject.
>
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
> drivers/staging/fbtft/fb_pcd8544.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index cf87ce8..925511f 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -34,8 +34,8 @@
> #define WIDTH 84
> #define HEIGHT 48
> #define TXBUFLEN (84*6)
> -#define DEFAULT_GAMMA "40"
> /* gamma is used to control contrast in this driver */
Aren't these two supposed to be on the same line? I think your patch is a bit
messed up. Doublecheck this.
> +#define DEFAULT_GAMMA "40"
>
> static unsigned tc;
> module_param(tc, uint, 0);
> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: fbtft: Made into two lines
2015-08-21 13:08 [PATCH] staging: fbtft: Made into two lines Aparna Karuthodi
2015-08-23 7:52 ` Giedrius Statkevičius
2015-08-23 13:30 ` Aparna Karuthodi
@ 2015-08-24 13:11 ` Sudip Mukherjee
2 siblings, 0 replies; 6+ messages in thread
From: Sudip Mukherjee @ 2015-08-24 13:11 UTC (permalink / raw)
To: Aparna Karuthodi; +Cc: gregkh, devel, noralf, linux-kernel
On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote:
> Made the comment into a new lineto remove a coding style error detected
> by checkpatch.
> The warning is given below:
> drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters
>
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
Please update your tree. This will also not apply for:
4178549e4c47 ("Staging: fbtft: fb_pcd8544: Fix comments style")
regards
sudip
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-08-24 19:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-21 13:08 [PATCH] staging: fbtft: Made into two lines Aparna Karuthodi
2015-08-23 7:52 ` Giedrius Statkevičius
2015-08-23 13:30 ` Aparna Karuthodi
2015-08-24 19:08 ` Giedrius Statkevičius
2015-08-24 19:33 ` Giedrius Statkevičius
2015-08-24 13:11 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox