From: Vinod Koul <vinod.koul@intel.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH] drivers/dma: make mv_xor.c driver explicitly non-modular
Date: Sun, 23 Aug 2015 19:15:16 +0530 [thread overview]
Message-ID: <20150823134516.GZ13546@localhost> (raw)
In-Reply-To: <1440188869-29708-1-git-send-email-paul.gortmaker@windriver.com>
On Fri, Aug 21, 2015 at 04:27:49PM -0400, Paul Gortmaker wrote:
> The Kconfig for this driver is currently:
>
> config MV_XOR
> bool "Marvell XOR engine support"
>
> ...meaning that it currently is not being built as a module by anyone.
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering remains unchanged with this commit.
>
> We leave some tags like MODULE_AUTHOR for documentation purposes.
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2015-08-23 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 20:27 [PATCH] drivers/dma: make mv_xor.c driver explicitly non-modular Paul Gortmaker
2015-08-23 13:45 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150823134516.GZ13546@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox