From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752737AbbHWNnI (ORCPT ); Sun, 23 Aug 2015 09:43:08 -0400 Received: from mga11.intel.com ([192.55.52.93]:50215 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260AbbHWNnG (ORCPT ); Sun, 23 Aug 2015 09:43:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,732,1432623600"; d="scan'208";a="630674601" Date: Sun, 23 Aug 2015 19:15:16 +0530 From: Vinod Koul To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Dan Williams , dmaengine@vger.kernel.org Subject: Re: [PATCH] drivers/dma: make mv_xor.c driver explicitly non-modular Message-ID: <20150823134516.GZ13546@localhost> References: <1440188869-29708-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1440188869-29708-1-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 21, 2015 at 04:27:49PM -0400, Paul Gortmaker wrote: > The Kconfig for this driver is currently: > > config MV_XOR > bool "Marvell XOR engine support" > > ...meaning that it currently is not being built as a module by anyone. > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > We leave some tags like MODULE_AUTHOR for documentation purposes. > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. Applied, thanks -- ~Vinod