* [RESEND PATCH] cpufreq: cpufreq: Fix coding style issues
@ 2015-08-23 16:43 Muhammad Falak R Wani
2015-08-24 4:25 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Falak R Wani @ 2015-08-23 16:43 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, linux-pm, linux-kernel
Cc: Muhammad Falak R Wani
This patch introduces a blank line after declarations, which
fix the checkpatch.pl warnings at 3 places.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
drivers/cpufreq/cpufreq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 8ae655c..5aea659 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -718,6 +718,7 @@ static ssize_t show_bios_limit(struct cpufreq_policy *policy, char *buf)
{
unsigned int limit;
int ret;
+
if (cpufreq_driver->bios_limit) {
ret = cpufreq_driver->bios_limit(policy->cpu, &limit);
if (!ret)
@@ -815,6 +816,7 @@ unlock:
static void cpufreq_sysfs_release(struct kobject *kobj)
{
struct cpufreq_policy *policy = to_policy(kobj);
+
pr_debug("last reference is dropped\n");
complete(&policy->kobj_unregister);
}
@@ -2129,6 +2131,7 @@ EXPORT_SYMBOL_GPL(cpufreq_unregister_governor);
int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu)
{
struct cpufreq_policy *cpu_policy;
+
if (!policy)
return -EINVAL;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [RESEND PATCH] cpufreq: cpufreq: Fix coding style issues
2015-08-23 16:43 [RESEND PATCH] cpufreq: cpufreq: Fix coding style issues Muhammad Falak R Wani
@ 2015-08-24 4:25 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2015-08-24 4:25 UTC (permalink / raw)
To: Muhammad Falak R Wani; +Cc: Rafael J. Wysocki, linux-pm, linux-kernel
On 23-08-15, 22:13, Muhammad Falak R Wani wrote:
> This patch introduces a blank line after declarations, which
> fix the checkpatch.pl warnings at 3 places.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> drivers/cpufreq/cpufreq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 8ae655c..5aea659 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -718,6 +718,7 @@ static ssize_t show_bios_limit(struct cpufreq_policy *policy, char *buf)
> {
> unsigned int limit;
> int ret;
> +
> if (cpufreq_driver->bios_limit) {
> ret = cpufreq_driver->bios_limit(policy->cpu, &limit);
> if (!ret)
> @@ -815,6 +816,7 @@ unlock:
> static void cpufreq_sysfs_release(struct kobject *kobj)
> {
> struct cpufreq_policy *policy = to_policy(kobj);
> +
> pr_debug("last reference is dropped\n");
> complete(&policy->kobj_unregister);
> }
> @@ -2129,6 +2131,7 @@ EXPORT_SYMBOL_GPL(cpufreq_unregister_governor);
> int cpufreq_get_policy(struct cpufreq_policy *policy, unsigned int cpu)
> {
> struct cpufreq_policy *cpu_policy;
> +
> if (!policy)
> return -EINVAL;
We don't really need a patch for this, unless Rafael wants to apply
this one :)
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-24 4:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-23 16:43 [RESEND PATCH] cpufreq: cpufreq: Fix coding style issues Muhammad Falak R Wani
2015-08-24 4:25 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox