From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932405AbbHXGqw (ORCPT ); Mon, 24 Aug 2015 02:46:52 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:36181 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932184AbbHXGqv (ORCPT ); Mon, 24 Aug 2015 02:46:51 -0400 Date: Mon, 24 Aug 2015 08:46:47 +0200 From: Ingo Molnar To: Denys Vlasenko Cc: Borislav Petkov , "H. Peter Anvin" , Andy Lutomirski , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/math-emu: Add support for FCMOVcc and F[U]COMI[P] insns Message-ID: <20150824064647.GA12756@gmail.com> References: <1440152395-19818-1-git-send-email-dvlasenk@redhat.com> <20150822085453.GB10490@gmail.com> <55D8C61B.3010902@redhat.com> <20150823061517.GA18134@gmail.com> <55D9EB14.9010102@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55D9EB14.9010102@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Denys Vlasenko wrote: > I propose the table to be commented like shown below: > > /*Opcode: d8 d9 da db dc dd de df */ > /*c0..f*/ fadd__, fld_i_, fcmovb, fcmovnb, fadd_i, ffree_, faddp_, _df_c0_, > /*c8..f*/ fmul__, fxch_i, fcmove, fcmovne, fmul_i, _dd_c8_,fmulp_, _df_c8_, > /*d0..7*/ fcom_st,fp_nop, fcmovbe,fcmovnbe,_dc_d0_,fst_i_, _de_d0_,_df_d0_, > /*d8..f*/ fcompst,_d9_d8_, fcmovu, fcmovnu, _dc_d8_,fstp_i, fcompp, _df_d8_, > /*e0..7*/ fsub__, FPU_etc, __BAD__,finit_, fsubri, fucom_, fsubrp, fstsw_, > /*e8..f*/ fsubr_, fconst, fucompp,fucomi_, fsub_i, fucomp, fsubp_, fucomip, > /*f0..7*/ fdiv__, FPU_triga,__BAD__,fcomi_, fdivri, __BAD__,fdivrp, fcomip, > /*f8..f*/ fdivr_, FPU_trigb,__BAD__,__BAD__, fdiv_i, __BAD__,fdivp_, __BAD__, I agree with that, but please fix the vertical alignment (like my patch did), as the table is pretty hard to navigate in this form. Also, the first patch in the series should remove the 'undocumented' #ifdef. That define was fully justified ~20 years ago but let's not complicate new code with it. Thanks, Ingo